From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2] ACPI / PMIC: Add opregion driver for Intel CHT WhiskeyCove PMIC Date: Tue, 28 Feb 2017 13:27:22 +0200 Message-ID: <1488281242.20145.53.camel@linux.intel.com> References: <20170227202628.5737-1-hdegoede@redhat.com> <62049bce-0aad-8f08-23fd-23be769c9e19@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga07.intel.com ([134.134.136.100]:56819 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751728AbdB1Lar (ORCPT ); Tue, 28 Feb 2017 06:30:47 -0500 In-Reply-To: <62049bce-0aad-8f08-23fd-23be769c9e19@redhat.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Hans de Goede , Andy Shevchenko Cc: "Rafael J . Wysocki" , Len Brown , Darren Hart , Andy Shevchenko , "linux-acpi@vger.kernel.org" , Takashi Iwai , Bin Gao , Felipe Balbi On Tue, 2017-02-28 at 12:18 +0100, Hans de Goede wrote: > Hi, > > Thnak you for the review. > > On 27-02-17 22:50, Andy Shevchenko wrote: > > On Mon, Feb 27, 2017 at 10:26 PM, Hans de Goede > > wrote: > > > Add opregion driver for Intel CHT WhiskeyCove PMIC, based on > > > various > > > non upstreamed CHT WhiskeyCove PMIC patches. This does not include > > > support for the Thermal opregion (DPTF) due to lacking > > > documentation. > > > > Couple of nitpicks. > > > > > @@ -0,0 +1,232 @@ > > > +/* > > > + * intel_pmic_chtwc.c - Intel CHT Whiskey Cove PMIC operation > > > region driver > > > > I would remove file name. You never know if it's going to be renamed > > or not. > > > > > +static int intel_cht_wc_pmic_update_power(struct regmap *regmap, > > > int reg, > > > +               int bit, bool on) > > > +{ > > > +       u8 mask = bit; > > > + > > > +       return regmap_update_bits(regmap, reg, mask, on ? 1 : 0); > > > > Hmm... Just leave one line? > > Both fixed. I will send a new version together with a new version > of the Intel CHT WhiskeyCove PMIC mfd driver. Please add my Reviewed-by: Andy Shevchenko -- Andy Shevchenko Intel Finland Oy