From: Shanker Donthineni <shankerd@codeaurora.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Viram Sethi <vikrams@codeaurora.org>,
Shanker Donthineni <shankerd@codeaurora.org>
Subject: [PATCH v2] ACPI : Update platform device numa node based on _PXM method
Date: Wed, 29 Mar 2017 06:39:19 -0500 [thread overview]
Message-ID: <1490787559-15722-1-git-send-email-shankerd@codeaurora.org> (raw)
The optional _PXM method evaluates to an integer that identifies the
proximity domain of a device object. On ACPI based kernel boot, the
field numa_node in 'struct device' is always set to -1 irrespective
of _PXM value that is specified in the ACPI device object. But in
case of device-tree based kernel boot the numa_node field is populated
and reflects to a DT property that is specified in DTS according to
the below document.
https://www.kernel.org/doc/Documentation/devicetree/bindings/numa.txt
http://lxr.free-electrons.com/source/drivers/of/device.c#L54
Without this patch dev_to_node() always returns a value of -1 for all
platform devices. This patch implements support for ACPI _PXM method
and updates the platform device numa node id using acpi_get_node(),
which provides the PXM to NUMA mapping information. The individual
platform device drivers should be able to use the NUMA aware memory
allocation functions kmalloc_node() and alloc_pages_node() to improve
the performance.
Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
---
Changes since v1: Edited commit text.
Not all the platform devices are attached to NUMA node 0 on Qualcomm
Datacenter Technologies server chips. Platform device drivers needs
to be aware of NUMA information to improve performance.
drivers/acpi/acpi_platform.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
index b4c1a6a..83d953e 100644
--- a/drivers/acpi/acpi_platform.c
+++ b/drivers/acpi/acpi_platform.c
@@ -119,11 +119,14 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev,
if (IS_ERR(pdev))
dev_err(&adev->dev, "platform device creation failed: %ld\n",
PTR_ERR(pdev));
- else
+ else {
+ set_dev_node(&pdev->dev, acpi_get_node(adev->handle));
dev_dbg(&adev->dev, "created platform device %s\n",
dev_name(&pdev->dev));
+ }
kfree(resources);
+
return pdev;
}
EXPORT_SYMBOL_GPL(acpi_create_platform_device);
--
Qualcomm Datacenter Technologies, Inc. on behalf of the Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next reply other threads:[~2017-03-29 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 11:39 Shanker Donthineni [this message]
2017-04-12 8:42 ` [PATCH v2] ACPI : Update platform device numa node based on _PXM method Hanjun Guo
2017-04-14 22:42 ` Jiandi An
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490787559-15722-1-git-send-email-shankerd@codeaurora.org \
--to=shankerd@codeaurora.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).