Re: [PATCH 3/3] ACPI / X86: Add KIOX000A accelerometer on GPD win to always_present_ids array

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, 2017-07-10 at 12:25 +0200, Hans de Goede wrote:
> Hi,
> 
> On 10-07-17 12:22, Andy Shevchenko wrote:
> > On Sun, 2017-07-09 at 21:05 +0200, Hans de Goede wrote:
> > > The GPD win BIOS dated 20170320 has disabled the accelerometer,
> > > the
> > > drivers sometimes cause crashes under Windows and this is how the
> > > manufacturer has solved this :|
> > > 
> > > I see no other way to keep the accelerometer working under Windows
> > > then
> > > adding it to the always_present_ids array.
> > > 
> > > +	ENTRY("KIOX000A", "1", ICPU(INTEL_FAM6_ATOM_AIRMONT), {
> > > +		DMI_MATCH(DMI_BOARD_VENDOR, "AMI Corporation"),

> > > +		DMI_MATCH(DMI_BOARD_NAME, "Default string"),
> > > +		DMI_MATCH(DMI_PRODUCT_NAME, "Default string"),

Just noticed above, don't think it's a good idea to place kinda defaults
there.

> > > +		DMI_MATCH(DMI_BIOS_DATE, "03/20/2017")
> > 
> > 4 entries for 2 entry array?
> 
> No, there are 2 dmi_system_id array entries, one with the
> actual id, one empty to terminate the array. The
> dmi_system_id array entry has a matches array which is 4 big:
> 
> struct dmi_system_id {
>          int (*callback)(const struct dmi_system_id *);
>          const char *ident;
>          struct dmi_strmatch matches[4];
>          void *driver_data;
> };
> 
> And the ENTRY macro puts the passed in arguments into the matches
> array.

Ah, indeed. Thanks for explanation.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy