Linux ACPI
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: linux-acpi@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.de>, Thomas Renninger <trenn@suse.de>,
	Alan Jenkins <sourcejedi.lkml@googlemail.com>,
	Len Brown <len.brown@intel.com>
Subject: [PATCH 2/5] ACPI: Clarify resource conflict message
Date: Sun, 27 Sep 2009 04:32:42 -0400	[thread overview]
Message-ID: <14f03343ad1080c2fea29ab2c13f05b976c4584e.1254040242.git.len.brown@intel.com> (raw)
In-Reply-To: <1254040365-18971-1-git-send-email-lenb@kernel.org>
In-Reply-To: <b684a3637e0887683a0a3d6fd471fc41d7c1606a.1254040242.git.len.brown@intel.com>

From: Jean Delvare <jdelvare@suse.de>

The message "ACPI: Device needs an ACPI driver" is misleading. The
device _may_ need an ACPI driver, if the BIOS implemented a custom
API for the device in question (which, AFAIK, can't be checked.) If
not, then either a generic ACPI driver may be used (for example
"thermal"), or nothing can be done (other than a white list).

I propose to reword the message to:

ACPI: If an ACPI driver is available for this device, you should use
it instead of the native driver

which I think is more correct. Comments and suggestions welcome.

I also added a message warning about possible problems and system
instability when users pass acpi_enforce_resources=lax, as suggested
by Len.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Alan Jenkins <sourcejedi.lkml@googlemail.com>
Signed-off-by: Len Brown <len.brown@intel.com>
---
 drivers/acpi/osl.c |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 5633b86..7c1c59e 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1161,7 +1161,13 @@ int acpi_check_resource_conflict(struct resource *res)
 			       res_list_elem->name,
 			       (long long) res_list_elem->start,
 			       (long long) res_list_elem->end);
-			printk(KERN_INFO "ACPI: Device needs an ACPI driver\n");
+			if (acpi_enforce_resources == ENFORCE_RESOURCES_LAX)
+				printk(KERN_NOTICE "ACPI: This conflict may"
+				       " cause random problems and system"
+				       " instability\n");
+			printk(KERN_INFO "ACPI: If an ACPI driver is available"
+			       " for this device, you should use it instead of"
+			       " the native driver\n");
 		}
 		if (acpi_enforce_resources == ENFORCE_RESOURCES_STRICT)
 			return -EBUSY;
-- 
1.6.0.6


  reply	other threads:[~2009-09-27  8:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-27  8:32 ACPI patches for 2.6.31-rc0 - part 3 Len Brown
2009-09-27  8:32 ` [PATCH 1/5] thinkpad-acpi: fix CONFIG_THINKPAD_ACPI_HOTKEY_POLL build problem Len Brown
2009-09-27  8:32   ` Len Brown [this message]
2009-09-27  8:32   ` [PATCH 3/5] ACPI: fix Compaq Evo N800c (Pentium 4m) boot hang regression Len Brown
2009-09-27  8:32   ` [PATCH 4/5] ACPI: Kill overly verbose "power state" log messages Len Brown
2009-09-27  8:32   ` [PATCH 5/5] ACPI: IA64=y ACPI=n build fix Len Brown
2009-09-27 11:10 ` ACPI patches for 2.6.31-rc0 - part 3 Mattia Dongili
2009-09-28  3:25   ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14f03343ad1080c2fea29ab2c13f05b976c4584e.1254040242.git.len.brown@intel.com \
    --to=lenb@kernel.org \
    --cc=jdelvare@suse.de \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=sourcejedi.lkml@googlemail.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox