Re: [PATCH v2 4/7] ghes_edac: avoid multiple calls to dmi_walk()

Borislav Petkov
2017-08-16T14:03:58Z

On Wed, Aug 16, 2017 at 09:59:01AM -0400, Steven Rostedt wrote:
> Should the above be:
>
> if (WARN_ON_ONCE(in_nmi()))
> return;
>
> To prevent a deadlock? Or do we not care?

Yeah, better this way.

> What's the likelihood of two calls to ghes_edac_register being done
> simultaneously? Because two calls at the same time will get past this.

Well, that thing gets called per GHES platform device and last time I
checked they do get probed back-to-back but I'll check that again.

Thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.