RE: [PATCH] SMP parsing rewrite, phase 1

Grover, Andrew
2003-01-21T18:36:46Z

> From: Martin J. Bligh [mailto:mbligh-/CzTsIfkJEdBDgjK7y7TUQ@public.gmane.org]

> Would be a lot easier to read if you could seperate out the
> renames from the rest of the patch that actually does things.
> It all makes me slightly nervous as this stuff is really easy
> to break ... and it breaks wierd machines that are hard to test
> for (been there, done that ;-)).

Exactly why I wanted to clean up the code - too fragile! :)

Anyways, I will take a stab at redoing the changesets the way you
describe.

> +static u8 raw_phys_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] =
> BAD_APICID };
>
> Looks odd. May have merged forward badly, that got renamed in 2.5.59
> to bios_cpu_apicid or something.

You are right. I'll fix that.

> Anyway, I'll give it a spin on my wierdo box, and see what happens.

Cool, thanks.

Regards -- Andy