Re: [PATCH] SMP parsing rewrite, phase 1

Martin J. Bligh
2003-01-21T04:28:20Z

Would be a lot easier to read if you could seperate out the
renames from the rest of the patch that actually does things.
It all makes me slightly nervous as this stuff is really easy
to break ... and it breaks wierd machines that are hard to test
for (been there, done that ;-)).

+static u8 raw_phys_apicid[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };

Looks odd. May have merged forward badly, that got renamed in 2.5.59
to bios_cpu_apicid or something.

Anyway, I'll give it a spin on my wierdo box, and see what happens.

M.