From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Carlo Caione <carlo@endlessm.com>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH V2] ACPI / LPSS: Add device link for CHT SD card dependency on I2C
Date: Fri, 15 Dec 2017 12:03:37 +0200 [thread overview]
Message-ID: <1513332217.7000.81.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0hLBODV4Tfh-TMa6Psh16Bbs_d9x51xjrweGGHAPpqqqQ@mail.gmail.com>
On Fri, 2017-12-15 at 01:58 +0100, Rafael J. Wysocki wrote:
> On Thu, Dec 14, 2017 at 3:16 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Thu, 2017-12-07 at 11:03 +0200, Adrian Hunter wrote:
> > >
> > >
> > > +static const struct x86_cpu_id cht_cpu[] = {
> > > + ICPU(INTEL_FAM6_ATOM_AIRMONT), /* Braswell, Cherry
> > > Trail */
> > > + {}
> > > +};
> >
> > I would rather to modify ICPU() macro to accept driver data where we
> > just pass an unsigned long value to be assigned as lpss_quirks and
> > introduce another quirk.
>
> Not really.
>
> There are many instances of ICPU() already in the tree and updating
> all of them is just not worth it.
These macros all over the code are local.
I'm talking about one which is defined inside acpi_lpss.c.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2017-12-15 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 9:03 [PATCH V2] ACPI / LPSS: Add device link for CHT SD card dependency on I2C Adrian Hunter
2017-12-14 14:16 ` Andy Shevchenko
2017-12-15 0:58 ` Rafael J. Wysocki
2017-12-15 10:03 ` Andy Shevchenko [this message]
2017-12-15 9:10 ` Adrian Hunter
2017-12-15 12:00 ` Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513332217.7000.81.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adrian.hunter@intel.com \
--cc=carlo@endlessm.com \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox