From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 3/3] x86/platform/intel-mid: Add special handling of ACPI HW reduced platforms
Date: Wed, 17 Jan 2018 19:43:52 +0200 [thread overview]
Message-ID: <1516211032.7000.1049.camel@linux.intel.com> (raw)
In-Reply-To: <20180117173409.88136-3-andriy.shevchenko@linux.intel.com>
On Wed, 2018-01-17 at 19:34 +0200, Andy Shevchenko wrote:
> When switching to ACPI HW reduced platforms we still want to
> initialize timers.
> Override acpi_reduced_hw_init() to achieve that.
Just realized, that it may annihilate the other acpi_reduced_hw_init()
on non-MID platforms...
Open to suggestions how would be better to deal with this (I really
don't like the idea to spread MID quirks all over the code).
P.S. Patch 2 from the series still makes sense per se.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/platform/intel-mid/intel-mid.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/x86/platform/intel-mid/intel-mid.c
> b/arch/x86/platform/intel-mid/intel-mid.c
> index 2c67bae6bb53..51bf2f6c9e97 100644
> --- a/arch/x86/platform/intel-mid/intel-mid.c
> +++ b/arch/x86/platform/intel-mid/intel-mid.c
> @@ -13,6 +13,7 @@
>
> #define pr_fmt(fmt) "intel_mid: " fmt
>
> +#include <linux/acpi.h>
> #include <linux/init.h>
> #include <linux/kernel.h>
> #include <linux/interrupt.h>
> @@ -172,6 +173,14 @@ static unsigned char
> intel_mid_get_nmi_reason(void)
> return 0;
> }
>
> +void __init acpi_reduced_hw_init(void)
> +{
> + /*
> + * Do nothing for now as everything needed done in
> + * x86_intel_mid_early_setup() below.
> + */
> +}
> +
> /*
> * Moorestown specific x86_init function overrides and early setup
> * calls.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-01-17 17:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 17:34 [PATCH v1 1/3] ACPI / x86: boot: Not all platforms require acpi_reduced_hw_init() Andy Shevchenko
2018-01-17 17:34 ` [PATCH v1 2/3] x86/platform/intel-mid: Move PCI initialization to arch_init() Andy Shevchenko
2018-01-17 17:34 ` [PATCH v1 3/3] x86/platform/intel-mid: Add special handling of ACPI HW reduced platforms Andy Shevchenko
2018-01-17 17:43 ` Andy Shevchenko [this message]
2018-01-19 8:15 ` Ingo Molnar
2018-02-04 8:54 ` [PATCH v1 1/3] ACPI / x86: boot: Not all platforms require acpi_reduced_hw_init() Rafael J. Wysocki
2018-02-04 14:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516211032.7000.1049.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).