[PATCH v2] ACPI / tables: Add IORT to injectable table list

[PATCH v2] ACPI / tables: Add IORT to injectable table list

[Yang Shunyong]

This patch adds ACPI_SIG_IORT to the table, which enables IORT from
initrd to override which from firmware.

Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
Cc: yutang2.jiang@hxt-semitech.com
Cc: yu.zheng@hxt-semitech.com
---

v2: change typo ACPI_SIG_PPTT to ACPI_SIG_IORT in commit message.

---
 drivers/acpi/tables.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 80ce2a7d224b..7bcb66ccccf3 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -456,7 +456,8 @@ static u8 __init acpi_table_checksum(u8 *buffer, u32 length)
 	ACPI_SIG_SLIC, ACPI_SIG_SPCR, ACPI_SIG_SPMI, ACPI_SIG_TCPA,
 	ACPI_SIG_UEFI, ACPI_SIG_WAET, ACPI_SIG_WDAT, ACPI_SIG_WDDT,
 	ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT,
-	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, NULL };
+	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_IORT,
+	NULL };
 
 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
 
-- 
1.8.3.1

Re: [PATCH v2] ACPI / tables: Add IORT to injectable table list

[Yang, Shunyong]

Hi, Rafael

Could you please help to review this patch? This is a small change to
add ACPI_SIG_IORT to table_sigs[]. 
Loading IORT table from initrd is very useful to debug SMMU node/device
probe, MSI allocation, stream id translation and verifying IORT table
from firmware. So, I add this.

Thanks
Shunyong.

On Tue, 2018-01-23 at 16:25 +0800, Yang Shunyong wrote:
> This patch adds ACPI_SIG_IORT to the table, which enables IORT from
> initrd to override which from firmware.
> 
> Signed-off-by: Yang Shunyong <shunyong.yang@hxt-semitech.com>
> Cc: yutang2.jiang@hxt-semitech.com
> Cc: yu.zheng@hxt-semitech.com
> ---
> 
> v2: change typo ACPI_SIG_PPTT to ACPI_SIG_IORT in commit message.
> 
> ---
>  drivers/acpi/tables.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 80ce2a7d224b..7bcb66ccccf3 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -456,7 +456,8 @@ static u8 __init acpi_table_checksum(u8 *buffer,
> u32 length)
>  	ACPI_SIG_SLIC, ACPI_SIG_SPCR, ACPI_SIG_SPMI, ACPI_SIG_TCPA,
>  	ACPI_SIG_UEFI, ACPI_SIG_WAET, ACPI_SIG_WDAT, ACPI_SIG_WDDT,
>  	ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT,
> -	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, NULL };
> +	ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, ACPI_SIG_IORT,
> +	NULL };
>  
>  #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)
>  

Re: [PATCH v2] ACPI / tables: Add IORT to injectable table list

[Hanjun Guo]

Hi Shunyong,

On 2018/1/30 9:44, Yang, Shunyong wrote:
> Hi, Rafael
> 
> Could you please help to review this patch? This is a small change to
> add ACPI_SIG_IORT to table_sigs[]. 
> Loading IORT table from initrd is very useful to debug SMMU node/device
> probe, MSI allocation, stream id translation and verifying IORT table
> from firmware. So, I add this.

It's true, mappings in IORT will be easy getting wrong, so it would be
good to test it without updating the firmware.

But I think you'd better to add your comment about why you need
IORT in the commit message in your patch, that will be useful
to convince Rafael to take your patch.

Thanks
Hanjun

Re: [PATCH v2] ACPI / tables: Add IORT to injectable table list

[Yang, Shunyong]

Hi, Hanjun

On Wed, 2018-01-31 at 21:32 +0800, Hanjun Guo wrote:
> Hi Shunyong,
> 
> On 2018/1/30 9:44, Yang, Shunyong wrote:
> > 
> > Hi, Rafael
> > 
> > Could you please help to review this patch? This is a small change
> > to
> > add ACPI_SIG_IORT to table_sigs[]. 
> > Loading IORT table from initrd is very useful to debug SMMU
> > node/device
> > probe, MSI allocation, stream id translation and verifying IORT
> > table
> > from firmware. So, I add this.
> It's true, mappings in IORT will be easy getting wrong, so it would
> be
> good to test it without updating the firmware.
> 
> But I think you'd better to add your comment about why you need
> IORT in the commit message in your patch, that will be useful
> to convince Rafael to take your patch.
> 

Thanks for your suggestion. I will add detailed information to commit
message and send out v3 later.

Thanks.
Shunyong.