From: Sinan Kaya <okaya@codeaurora.org>
To: linux-acpi@vger.kernel.org, timur@codeaurora.org
Cc: eric.auger@redhat.com, hdegoede@redhat.com,
mika.westerberg@linux.intel.com, wsa@the-dreams.de,
linux-i2c@vger.kernel.org, rjw@rjwysocki.net,
Sinan Kaya <okaya@codeaurora.org>, Len Brown <lenb@kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v3] ACPI: Force I2C to be selected as a built-in module
Date: Thu, 25 Jan 2018 10:43:31 -0500 [thread overview]
Message-ID: <1516895011-17588-1-git-send-email-okaya@codeaurora.org> (raw)
From: Auger Eric <eric.auger@redhat.com>
If I2C is built as a module, ACPI_I2C_OPREGION cannot be set
and any ACPI opregion calls targeting I2C fail with no opregion found.
Commit da3c6647ee08 ("I2C/ACPI: Clean up I2C ACPI code and Add
CONFIG_I2C_ACPI config") says following:
"Current there is a race between removing I2C ACPI operation region
and ACPI AML code accessing."
This patch forces core I2C support to be compiled as a built-in
module if ACPI is selected as code is not ready for dynamic module
removal.
Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
drivers/acpi/Kconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 4650539..5b48098 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -9,6 +9,8 @@ menuconfig ACPI
depends on IA64 || X86 || ARM64
depends on PCI
select PNP
+ # force building I2C in on ACPI systems, for opregion availability
+ imply I2C
default y if (IA64 || X86)
help
Advanced Configuration and Power Interface (ACPI) support for
--
1.9.1
next reply other threads:[~2018-01-25 15:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 15:43 Sinan Kaya [this message]
2018-01-25 16:25 ` [PATCH v3] ACPI: Force I2C to be selected as a built-in module Rafael J. Wysocki
2018-01-25 16:32 ` Sinan Kaya
2018-01-25 16:47 ` Rafael J. Wysocki
2018-01-25 16:53 ` Sinan Kaya
2018-01-25 16:57 ` Rafael J. Wysocki
2018-01-25 17:07 ` Sinan Kaya
2018-01-25 17:11 ` Hans de Goede
2018-01-25 17:36 ` Randy Dunlap
2018-02-06 14:25 ` Sinan Kaya
2018-02-08 9:52 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1516895011-17588-1-git-send-email-okaya@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=eric.auger@redhat.com \
--cc=hdegoede@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=timur@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox