From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Sinan Kaya <okaya@codeaurora.org>,
dmaengine <dmaengine@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-acpi@vger.kernel.org
Cc: Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table
Date: Thu, 01 Feb 2018 22:45:21 +0200 [thread overview]
Message-ID: <1517517921.7000.1447.camel@linux.intel.com> (raw)
In-Reply-To: <1517517646.7000.1446.camel@linux.intel.com>
On Thu, 2018-02-01 at 22:40 +0200, Andy Shevchenko wrote:
> On Thu, 2018-02-01 at 15:32 -0500, Sinan Kaya wrote:
> > On 2/1/2018 3:20 PM, Andy Shevchenko wrote:
> > > When __acpi_match_device() is called it would be possible to have
> > > ACPI ID table a MULL pointer. To avoid potential dereference,
> >
> > NULL
>
> Thanks, will fix later.
>
> > Why not bail out here immediately if ids is null?
>
> Because of the code which wasn't in context of this patch.
>
> See also patch 1 in the series.
>
> It's about how acpi_driver_match_device() uses it.
Btw, it makes device_get_match_data() to work properly on PRP0001 kind
of devices.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-02-01 20:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 20:20 [PATCH v2 1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
2018-02-01 20:32 ` Sinan Kaya
2018-02-01 20:40 ` Andy Shevchenko
2018-02-01 20:45 ` Andy Shevchenko [this message]
2018-02-04 7:18 ` Rafael J. Wysocki
2018-02-05 15:56 ` Andy Shevchenko
2018-02-05 15:59 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-01 20:46 ` Andy Shevchenko
2018-02-04 7:21 ` Rafael J. Wysocki
2018-02-05 16:04 ` Andy Shevchenko
2018-02-05 16:54 ` Rafael J. Wysocki
2018-02-06 12:51 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Andy Shevchenko
2018-02-04 7:23 ` Rafael J. Wysocki
2018-02-05 16:12 ` Andy Shevchenko
2018-02-05 16:53 ` Rafael J. Wysocki
2018-02-01 20:20 ` [PATCH v2 5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Andy Shevchenko
2018-02-04 14:06 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 6/6] device property: Constify device_get_match_data() Andy Shevchenko
2018-02-01 20:35 ` Sinan Kaya
2018-02-01 20:38 ` Andy Shevchenko
2018-02-01 20:40 ` Sinan Kaya
2018-02-01 21:23 ` Sakari Ailus
2018-02-04 7:16 ` [PATCH v2 1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Rafael J. Wysocki
2018-02-05 15:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517517921.7000.1447.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).