From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: dmaengine <dmaengine@vger.kernel.org>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Sinan Kaya <okaya@codeaurora.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Vinod Koul <vinod.koul@intel.com>
Subject: Re: [PATCH v2 4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data()
Date: Mon, 05 Feb 2018 18:12:02 +0200 [thread overview]
Message-ID: <1517847122.22495.35.camel@linux.intel.com> (raw)
In-Reply-To: <CAJZ5v0hssSqBDE8emBqKFQn9gXK1dBJwB4L0y=M5===YUXjTbQ@mail.gmail.com>
On Sun, 2018-02-04 at 08:23 +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 1, 2018 at 9:20 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > Do the renaming to be consistent with its sibling, i.e.
> > of_device_get_match_data().
> >
> > No functional change.
> >
> > Fixes: 80212a162329 ("ACPI / bus: Introduce acpi_get_match_data()
> > function")
> > Fixes: 146b4dbb0eef ("ACPI: properties: Implement get_match_data()
> > callback")
>
> Why are you adding the Fixes: tags to a patch that doesn't make any
> functional changes?
>
> What are they useful for?
Because next patch depends on this one and fixes API.
So, here the Fixes tags to be sure that next will apply cleanly.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-02-05 16:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 20:20 [PATCH v2 1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 2/6] ACPI / bus: Do not traverse through non-existed device table Andy Shevchenko
2018-02-01 20:32 ` Sinan Kaya
2018-02-01 20:40 ` Andy Shevchenko
2018-02-01 20:45 ` Andy Shevchenko
2018-02-04 7:18 ` Rafael J. Wysocki
2018-02-05 15:56 ` Andy Shevchenko
2018-02-05 15:59 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 3/6] ACPI / bus: Remove checks in acpi_get_match_data() Andy Shevchenko
2018-02-01 20:46 ` Andy Shevchenko
2018-02-04 7:21 ` Rafael J. Wysocki
2018-02-05 16:04 ` Andy Shevchenko
2018-02-05 16:54 ` Rafael J. Wysocki
2018-02-06 12:51 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 4/6] ACPI / bus: Rename acpi_get_match_data() to acpi_device_get_match_data() Andy Shevchenko
2018-02-04 7:23 ` Rafael J. Wysocki
2018-02-05 16:12 ` Andy Shevchenko [this message]
2018-02-05 16:53 ` Rafael J. Wysocki
2018-02-01 20:20 ` [PATCH v2 5/6] dmaengine: hidma: Constify returned by device_get_match_data() value Andy Shevchenko
2018-02-04 14:06 ` Andy Shevchenko
2018-02-01 20:20 ` [PATCH v2 6/6] device property: Constify device_get_match_data() Andy Shevchenko
2018-02-01 20:35 ` Sinan Kaya
2018-02-01 20:38 ` Andy Shevchenko
2018-02-01 20:40 ` Sinan Kaya
2018-02-01 21:23 ` Sakari Ailus
2018-02-04 7:16 ` [PATCH v2 1/6] ACPI / bus: Return error code from __acpi_match_device() in one case Rafael J. Wysocki
2018-02-05 15:56 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1517847122.22495.35.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=sakari.ailus@linux.intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).