[PATCH] acpi:ipmi: Convert ipmi_user_t to struct ipmi_user *

[PATCH] acpi:ipmi: Convert ipmi_user_t to struct ipmi_user *

[minyard]

From: Corey Minyard <cminyard@mvista.com>

Signed-off-by: Corey Minyard <cminyard@mvista.com>
Cc: Zhao Yakui <yakui.zhao@intel.com>
Cc: Lv Zheng <lv.zheng@intel.com>
---
 drivers/acpi/acpi_ipmi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

I'm getting rid of this annoying coding style violation, if you
could get this in that would be great.

diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
index 1b64419..712fd31 100644
--- a/drivers/acpi/acpi_ipmi.c
+++ b/drivers/acpi/acpi_ipmi.c
@@ -46,7 +46,7 @@ struct acpi_ipmi_device {
 	spinlock_t tx_msg_lock;
 	acpi_handle handle;
 	struct device *dev;
-	ipmi_user_t user_interface;
+	struct ipmi_user *user_interface;
 	int ipmi_ifnum; /* IPMI interface number */
 	long curr_msgid;
 	bool dead;
@@ -125,7 +125,7 @@ ipmi_dev_alloc(int iface, struct device *dev, acpi_handle handle)
 {
 	struct acpi_ipmi_device *ipmi_device;
 	int err;
-	ipmi_user_t user;
+	struct ipmi_user *user;
 
 	ipmi_device = kzalloc(sizeof(*ipmi_device), GFP_KERNEL);
 	if (!ipmi_device)
-- 
2.7.4


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot

Re: [PATCH] acpi:ipmi: Convert ipmi_user_t to struct ipmi_user *

[Rafael J. Wysocki]

On Wednesday, April 18, 2018 5:15:41 PM CEST minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
> 
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> Cc: Zhao Yakui <yakui.zhao@intel.com>
> Cc: Lv Zheng <lv.zheng@intel.com>
> ---
>  drivers/acpi/acpi_ipmi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> I'm getting rid of this annoying coding style violation, if you
> could get this in that would be great.
> 
> diff --git a/drivers/acpi/acpi_ipmi.c b/drivers/acpi/acpi_ipmi.c
> index 1b64419..712fd31 100644
> --- a/drivers/acpi/acpi_ipmi.c
> +++ b/drivers/acpi/acpi_ipmi.c
> @@ -46,7 +46,7 @@ struct acpi_ipmi_device {
>  	spinlock_t tx_msg_lock;
>  	acpi_handle handle;
>  	struct device *dev;
> -	ipmi_user_t user_interface;
> +	struct ipmi_user *user_interface;
>  	int ipmi_ifnum; /* IPMI interface number */
>  	long curr_msgid;
>  	bool dead;
> @@ -125,7 +125,7 @@ ipmi_dev_alloc(int iface, struct device *dev, acpi_handle handle)
>  {
>  	struct acpi_ipmi_device *ipmi_device;
>  	int err;
> -	ipmi_user_t user;
> +	struct ipmi_user *user;
>  
>  	ipmi_device = kzalloc(sizeof(*ipmi_device), GFP_KERNEL);
>  	if (!ipmi_device)
> 

FWIW:

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>



------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot