From: Oliver Neukum <oneukum@suse.com>
To: Charles.Hyde@dellteam.com, linux-usb@vger.kernel.org
Cc: Mario.Limonciello@dell.com, nic_swsd@realtek.com,
linux-acpi@vger.kernel.org
Subject: Re: [RFC 1/3] net: cdc_ncm: add get/set ethernet address functions
Date: Mon, 26 Aug 2019 10:59:43 +0200 [thread overview]
Message-ID: <1566809983.2612.2.camel@suse.com> (raw)
In-Reply-To: <d3971424f9ee4b689b762721f671746a@AUSX13MPS303.AMER.DELL.COM>
Am Freitag, den 23.08.2019, 22:26 +0000 schrieb
Charles.Hyde@dellteam.com:
> This patch adds support for pushing a MAC address out to USB based
> ethernet controllers driven by cdc_ncm. With this change, ifconfig can
> now set the device's MAC address. For example, the Dell Universal Dock
> D6000 is driven by cdc_ncm. The D6000 can now have its MAC address set
> by ifconfig, as it can be done in Windows. This was tested with a D6000
> using ifconfig on an x86 based chromebook, where iproute2 is not
> available.
The code is good. But placing it into cdc_ncm means that cdc_ether
or other drivers cannot use it.
Regards
Oliver
next prev parent reply other threads:[~2019-08-26 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 22:26 [RFC 1/3] net: cdc_ncm: add get/set ethernet address functions Charles.Hyde
2019-08-26 8:59 ` Oliver Neukum [this message]
2019-08-26 15:11 ` Mario.Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566809983.2612.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=Charles.Hyde@dellteam.com \
--cc=Mario.Limonciello@dell.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox