From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Andy Lutomirski <luto@kernel.org>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
Adrien Schildknecht <adrien+dev@schischi.me>,
Hans de Goede <hdegoede@redhat.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: 4.5 regression: ACPI hangs when backlight hotkeys are pressed
Date: Mon, 18 Jan 2016 23:25:10 +0100 [thread overview]
Message-ID: <1591964.NyM72FoSTm@vostro.rjw.lan> (raw)
In-Reply-To: <CALCETrXkN1=iT80Rv3J4ywJmkA8pMd7E+u1OytSZPwpPjr6y2A@mail.gmail.com>
On Monday, January 18, 2016 12:52:53 PM Andy Lutomirski wrote:
> I'm running 4.4 with the pm+acpi-4.5-rc1-1 merged in. After pressing
> the backlight hotkeys a couple times, things start to break. Poking
> at hung thread stacks, it appears that calls to
> acpi_video_handles_brightness_key_presses never return.
>
> It appears that the culprit is:
>
> commit aecbd9b1bff6afbe349921b406b99d285b412820
> Author: Adrien Schildknecht <adrien+dev@schischi.me>
> Date: Mon Jan 4 23:22:28 2016 +0100
>
> ACPI / video: driver must be registered before checking for keypresses
>
> Reverting that patch makes my laptop work again.
>
> I don't know what that patch is trying to do, but it looks highly
> questionable to me. Why should an accessor wait for a potential
> different driver to register something? I see no guarantee that it
> will eve happen.
>
> This is a Dell XPS 13 9350.
Should be fixed in my linux-next branch, can you please try that one?
Rafael
next prev parent reply other threads:[~2016-01-18 22:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 20:52 4.5 regression: ACPI hangs when backlight hotkeys are pressed Andy Lutomirski
2016-01-18 22:25 ` Rafael J. Wysocki [this message]
2016-01-18 23:04 ` Andy Lutomirski
2016-01-18 23:54 ` Rafael J. Wysocki
2016-01-18 23:57 ` Andy Lutomirski
2016-01-19 0:01 ` Rafael J. Wysocki
2016-01-19 0:09 ` Andy Lutomirski
2016-01-19 0:20 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591964.NyM72FoSTm@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=adrien+dev@schischi.me \
--cc=hdegoede@redhat.com \
--cc=linux-acpi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox