From: Hanjun Guo <guohanjun@huawei.com>
To: <linux-acpi@vger.kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Hanjun Guo <guohanjun@huawei.com>
Subject: [PATCH 07/25] ACPI: memhotplug: Remove the state for memory device
Date: Thu, 17 Sep 2020 15:38:47 +0800 [thread overview]
Message-ID: <1600328345-27627-8-git-send-email-guohanjun@huawei.com> (raw)
In-Reply-To: <1600328345-27627-1-git-send-email-guohanjun@huawei.com>
After commit ("315bbae9c5cb ACPI / memhotplug: deal with eject request
in hotplug queue"), the state for struct acpi_memory_device is not
actually useful, it can be removed.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/acpi_memhotplug.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
index 9cd987d..c8344b9 100644
--- a/drivers/acpi/acpi_memhotplug.c
+++ b/drivers/acpi/acpi_memhotplug.c
@@ -29,11 +29,6 @@
#ifdef CONFIG_ACPI_HOTPLUG_MEMORY
-/* Memory Device States */
-#define MEMORY_INVALID_STATE 0
-#define MEMORY_POWER_ON_STATE 1
-#define MEMORY_POWER_OFF_STATE 2
-
static int acpi_memory_device_add(struct acpi_device *device,
const struct acpi_device_id *not_used);
static void acpi_memory_device_remove(struct acpi_device *device);
@@ -58,7 +53,6 @@ struct acpi_memory_info {
struct acpi_memory_device {
struct acpi_device * device;
- unsigned int state; /* State of the memory device */
struct list_head res_list;
};
@@ -226,7 +220,6 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
}
if (!num_enabled) {
dev_err(&mem_device->device->dev, "add_memory failed\n");
- mem_device->state = MEMORY_INVALID_STATE;
return -EINVAL;
}
/*
@@ -297,9 +290,6 @@ static int acpi_memory_device_add(struct acpi_device *device,
return result;
}
- /* Set the device state */
- mem_device->state = MEMORY_POWER_ON_STATE;
-
result = acpi_memory_check_device(mem_device);
if (result) {
acpi_memory_device_free(mem_device);
--
1.7.12.4
next prev parent reply other threads:[~2020-09-17 8:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 7:38 [PATCH 00/25] ACPI: First step to decouple ACPICA debug functionality from ACPI driver Hanjun Guo
2020-09-17 7:38 ` [PATCH 01/25] ACPI: cmos_rtc: Remove the ACPI_MODULE_NAME() Hanjun Guo
2020-09-17 7:38 ` [PATCH 02/25] ACPI: configfs: Decouple with ACPICA Hanjun Guo
2020-09-17 7:38 ` [PATCH 03/25] ACPI: configfs: Add the missing config_item_put() Hanjun Guo
2020-09-17 7:38 ` [PATCH 04/25] ACPI: debug: Remove the not used function Hanjun Guo
2020-09-17 7:38 ` [PATCH 05/25] ACPI: LPSS: Remove the ACPI_MODULE_NAME() Hanjun Guo
2020-09-17 7:38 ` [PATCH 06/25] ACPI: memhotplug: Remove the leftover ACPICA debug functionality Hanjun Guo
2020-09-17 7:38 ` Hanjun Guo [this message]
2020-09-17 7:38 ` [PATCH 08/25] ACPI: platform: Remove the leftover ACPICA debug functinality Hanjun Guo
2020-09-17 7:38 ` [PATCH 09/25] ACPI: container: Remove the leftover ACPICA debug functionality Hanjun Guo
2020-09-17 7:38 ` [PATCH 10/25] ACPI: custom_method: Remove the ACPICA debug code Hanjun Guo
2020-09-17 7:38 ` [PATCH 11/25] ACPI: debugfs: " Hanjun Guo
2020-09-17 7:38 ` [PATCH 12/25] ACPI: dock: " Hanjun Guo
2020-09-17 7:38 ` [PATCH 13/25] ACPI: event: " Hanjun Guo
2020-09-17 7:38 ` [PATCH 14/25] ACPI: PCI: Remove the unused " Hanjun Guo
2020-09-17 7:38 ` [PATCH 15/25] ACPI: proc: " Hanjun Guo
2020-09-17 7:38 ` [PATCH 16/25] ACPI: processor: Remove the dead " Hanjun Guo
2020-09-17 7:38 ` [PATCH 17/25] ACPI: processor: Remove the duplicated ACPI_PROCESSOR_CLASS macro Hanjun Guo
2020-09-17 7:38 ` [PATCH 18/25] ACPI: SBS: Simplify the driver init code Hanjun Guo
2020-09-17 7:38 ` [PATCH 19/25] ACPI: SBS: Simplify the code using module_acpi_driver() Hanjun Guo
2020-09-17 7:39 ` [PATCH 20/25] ACPI: tiny-power-button: Remove the dead ACPICA debug code Hanjun Guo
2020-09-17 7:39 ` [PATCH 21/25] ACPI: tiny-power-button: Simplify the code using module_acpi_driver() Hanjun Guo
2020-09-17 7:39 ` [PATCH 22/25] ACPI: video: Remove the dead ACPICA debug code Hanjun Guo
2020-09-17 7:39 ` [PATCH 23/25] ACPI: wakeup: " Hanjun Guo
2020-09-17 7:39 ` [PATCH RFC 24/25] ACPI: sysfs: Remove the dead debug interfaces Hanjun Guo
2020-09-17 7:39 ` [PATCH RFC 25/25] ACPI: debug: Update the ACPI debug document Hanjun Guo
2020-09-17 15:08 ` [PATCH 00/25] ACPI: First step to decouple ACPICA debug functionality from ACPI driver Rafael J. Wysocki
2020-09-18 1:55 ` Hanjun Guo
2020-09-18 13:34 ` Rafael J. Wysocki
2020-09-19 7:22 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600328345-27627-8-git-send-email-guohanjun@huawei.com \
--to=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox