From: Hanjun Guo <guohanjun@huawei.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: <linux-acpi@vger.kernel.org>, Hanjun Guo <guohanjun@huawei.com>
Subject: [PATCH 1/2] ACPI: SBS: Simplify the driver init code
Date: Fri, 13 Nov 2020 10:25:10 +0800 [thread overview]
Message-ID: <1605234311-29912-1-git-send-email-guohanjun@huawei.com> (raw)
acpi_bus_register_driver() will check acpi_disable and return
-ENODEV, so the acpi_disable check outside the
acpi_bus_register_driver() is duplicated, can be removed.
Also we can just return from acpi_bus_register_driver() then
we can simplify the code further.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/sbs.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/acpi/sbs.c b/drivers/acpi/sbs.c
index e6d9f4d..cbd1af7 100644
--- a/drivers/acpi/sbs.c
+++ b/drivers/acpi/sbs.c
@@ -714,16 +714,7 @@ static int acpi_sbs_resume(struct device *dev)
static int __init acpi_sbs_init(void)
{
- int result = 0;
-
- if (acpi_disabled)
- return -ENODEV;
-
- result = acpi_bus_register_driver(&acpi_sbs_driver);
- if (result < 0)
- return -ENODEV;
-
- return 0;
+ return acpi_bus_register_driver(&acpi_sbs_driver);
}
static void __exit acpi_sbs_exit(void)
--
1.7.12.4
next reply other threads:[~2020-11-13 2:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 2:25 Hanjun Guo [this message]
2020-11-13 2:25 ` [PATCH 2/2] ACPI: SBS: Simplify the code using module_acpi_driver() Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605234311-29912-1-git-send-email-guohanjun@huawei.com \
--to=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox