From: Roman Kisel <romank@linux.microsoft.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
ardb@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com,
decui@microsoft.com, dimitri.sivanich@hpe.com,
haiyangz@microsoft.com, hpa@zytor.com, imran.f.khan@oracle.com,
jacob.jun.pan@linux.intel.com, jgross@suse.com,
justin.ernst@hpe.com, kprateek.nayak@amd.com, kyle.meyer@hpe.com,
kys@microsoft.com, lenb@kernel.org, mingo@redhat.com,
nikunj@amd.com, papaluri@amd.com, perry.yuan@amd.com,
peterz@infradead.org, rafael@kernel.org, russ.anderson@hpe.com,
steve.wahl@hpe.com, tim.c.chen@linux.intel.com,
tony.luck@intel.com, wei.liu@kernel.org, xin@zytor.com,
yuehaibing@huawei.com, linux-acpi@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org
Cc: apais@microsoft.com, benhill@microsoft.com,
bperkins@microsoft.com, sunilmut@microsoft.com
Subject: Re: [PATCH hyperv-next v2] arch/x86: Provide the CPU number in the wakeup AP callback
Date: Wed, 30 Apr 2025 13:09:54 -0700 [thread overview]
Message-ID: <16211a0d-b6bd-498a-adb5-7715e4013da1@linux.microsoft.com> (raw)
In-Reply-To: <877c31pgbm.ffs@tglx>
On 4/30/2025 1:03 PM, Thomas Gleixner wrote:
> On Wed, Apr 30 2025 at 14:44, Tom Lendacky wrote:
>> On 4/30/25 14:33, Thomas Gleixner wrote:
>>> bool __weak arch_match_cpu_phys_id(int cpu, u64 phys_id)
>>> {
>>> return (u32)phys_id == cpu;
>>> }
>>
>> There is an x86 version of this function in arch/x86/kernel/cpu/topology.c
>> that overrides the __weak definition and does:
>>
>> bool arch_match_cpu_phys_id(int cpu, u64 phys_id)
>> {
>> return phys_id == (u64)cpuid_to_apicid[cpu];
>> }
>
> Oops. I missed that somehow. So yes, aside of the signed/unsigned thing
> this looks fine.
>
Thomas,
Thanks a lot for the review! Will fix that in the next version.
> Thanks,
>
> tglx
>
--
Thank you,
Roman
prev parent reply other threads:[~2025-04-30 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 16:14 [PATCH hyperv-next v2] arch/x86: Provide the CPU number in the wakeup AP callback Roman Kisel
2025-04-30 18:04 ` Tom Lendacky
2025-04-30 19:52 ` Roman Kisel
2025-04-30 19:33 ` Thomas Gleixner
2025-04-30 19:44 ` Tom Lendacky
2025-04-30 20:03 ` Thomas Gleixner
2025-04-30 20:09 ` Roman Kisel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16211a0d-b6bd-498a-adb5-7715e4013da1@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=apais@microsoft.com \
--cc=ardb@kernel.org \
--cc=benhill@microsoft.com \
--cc=bp@alien8.de \
--cc=bperkins@microsoft.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=dimitri.sivanich@hpe.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=imran.f.khan@oracle.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jgross@suse.com \
--cc=justin.ernst@hpe.com \
--cc=kprateek.nayak@amd.com \
--cc=kyle.meyer@hpe.com \
--cc=kys@microsoft.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=papaluri@amd.com \
--cc=perry.yuan@amd.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=russ.anderson@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=tim.c.chen@linux.intel.com \
--cc=tony.luck@intel.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox