[PATCH] ACPI: configfs: Replace ACPI_INFO() with pr_debug()

[PATCH] ACPI: configfs: Replace ACPI_INFO() with pr_debug()

[Hanjun Guo]

The ACPI_INFO() macro is used for message printing in the ACPICA code.
ACPI_INFO() will be empty if the ACPICA debug is not enabled, so
it can be replaced with pr_debug().

Also remove the not needed acpica head file inclusions to decouple
with ACPICA.

Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---

Seems we missed this file for cleaning up the ACPICA message printing,
do it now.

 drivers/acpi/acpi_configfs.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_configfs.c
index 3a14859..76b83b1 100644
--- a/drivers/acpi/acpi_configfs.c
+++ b/drivers/acpi/acpi_configfs.c
@@ -13,9 +13,6 @@
 #include <linux/acpi.h>
 #include <linux/security.h>
 
-#include "acpica/accommon.h"
-#include "acpica/actables.h"
-
 static struct config_group *acpi_table_group;
 
 struct acpi_table {
@@ -226,7 +223,7 @@ static void acpi_table_drop_item(struct config_group *group,
 {
 	struct acpi_table *table = container_of(cfg, struct acpi_table, cfg);
 
-	ACPI_INFO(("Host-directed Dynamic ACPI Table Unload"));
+	pr_debug("Host-directed Dynamic ACPI Table Unload\n");
 	acpi_unload_table(table->index);
 	config_item_put(cfg);
 }
-- 
1.7.12.4

Re: [PATCH] ACPI: configfs: Replace ACPI_INFO() with pr_debug()

[Rafael J. Wysocki]

On Mon, May 24, 2021 at 11:51 AM Hanjun Guo <guohanjun@huawei.com> wrote:
>
> The ACPI_INFO() macro is used for message printing in the ACPICA code.
> ACPI_INFO() will be empty if the ACPICA debug is not enabled, so
> it can be replaced with pr_debug().
>
> Also remove the not needed acpica head file inclusions to decouple
> with ACPICA.
>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
>
> Seems we missed this file for cleaning up the ACPICA message printing,
> do it now.
>
>  drivers/acpi/acpi_configfs.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/acpi_configfs.c b/drivers/acpi/acpi_configfs.c
> index 3a14859..76b83b1 100644
> --- a/drivers/acpi/acpi_configfs.c
> +++ b/drivers/acpi/acpi_configfs.c
> @@ -13,9 +13,6 @@
>  #include <linux/acpi.h>
>  #include <linux/security.h>
>
> -#include "acpica/accommon.h"
> -#include "acpica/actables.h"
> -
>  static struct config_group *acpi_table_group;
>
>  struct acpi_table {
> @@ -226,7 +223,7 @@ static void acpi_table_drop_item(struct config_group *group,
>  {
>         struct acpi_table *table = container_of(cfg, struct acpi_table, cfg);
>
> -       ACPI_INFO(("Host-directed Dynamic ACPI Table Unload"));
> +       pr_debug("Host-directed Dynamic ACPI Table Unload\n");
>         acpi_unload_table(table->index);
>         config_item_put(cfg);
>  }
> --

Applied as 5.14 material with some edits in the changelog, thanks!