Re: [PATCH] ACPI / memhotplug: Fix a stale pointer in error path

Toshi Kani
2013-07-12T14:52:21Z

On Fri, 2013-07-12 at 09:24 +0900, Yasuaki Ishimatsu wrote:
> (2013/07/11 1:47), Toshi Kani wrote:
> > device->driver_data needs to be cleared when releasing its data,
> > mem_device, in an error path of acpi_memory_device_add().
> >
> > Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> > ---
>
> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

Thanks Yasuaki!
-Toshi

>
> Thanks,
> Yasuaki Ishimatsu
>
> > drivers/acpi/acpi_memhotplug.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> > index c711d11..999adb5 100644
> > --- a/drivers/acpi/acpi_memhotplug.c
> > +++ b/drivers/acpi/acpi_memhotplug.c
> > @@ -323,6 +323,7 @@ static int acpi_memory_device_add(struct acpi_device *device,
> > /* Get the range from the _CRS */
> > result = acpi_memory_get_device_resources(mem_device);
> > if (result) {
> > + device->driver_data = NULL;
> > kfree(mem_device);
> > return result;
> > }
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
>
>