Re: [PATCH v2 2/3] docs: firmware-guide: ACPI: Add named interrupt doc

Andy Shevchenko
2022-01-12T15:50:26Z

On Wed, Jan 12, 2022 at 4:15 PM Akhil R <akhilrajeev@nvidia.com> wrote:

Thanks for doing this, very helpful! My comments below.

> Added details and example for named interrupts in the ACPI Table

Table.

...

> +Named Interrupts
> +================
> +
> +Drivers with ACPI node can have names to interrupts in ACPI table which
> +can be used to get the irq number in the driver.

IRQ

> +The interrupt name can be listed in _DSD as 'interrupt-names'. The names
> +should be listed as an array of strings which will map to the Interrupt
> +property in ACPI table corresponding to its index.

'Interrupt property' --> 'Interrupt() resource'

the ACPI

> +The table below shows an example of its usage::
> +
> + Device (DEV0) {
> + ...
> + Name (_CRS, ResourceTemplate() {
> + ...
> + Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) {
> + 0x20,
> + 0x24
> + }
> + })
> +
> + Name (_DSD, Package () {
> + ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> + Package () {
> + Package () {"interrupt-names",
> + Package (2) {"default", "alert"}},
> + }

Package () {
Package () {
"interrupt-names", Package ()
{"default", "alert"}
},
}

> + ...
> + })
> + }

Please, drop the indentation to just 4 spaces.

> +The interrupt name 'default' will correspond to 0x20 in Interrupt property

Interrupt() resource

> +and 'alert' to 0x24.
> +
> +The driver can call the function - device_irq_get_byname with the device

device_irq_get_byname()

> +and interrupt name as arguments to get the corresponding irq number.

IRQ

--
With Best Regards,
Andy Shevchenko