* [PATCH] ACPI: AC: Remove the leftover struct acpi_ac_bl
@ 2022-09-17 9:45 Hanjun Guo
2022-09-17 10:39 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Hanjun Guo @ 2022-09-17 9:45 UTC (permalink / raw)
To: linux-acpi; +Cc: Rafael J. Wysocki, Hans de Goede, Hanjun Guo
In commit 57a183222271 ("ACPI / x86: Introduce an
acpi_quirk_skip_acpi_ac_and_battery() helper"), the usage of struct
acpi_ac_bl was removed, but left the definition of the struct in
the file, so remove the useless code.
Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
---
drivers/acpi/ac.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
index c29e41b..bb9fe79 100644
--- a/drivers/acpi/ac.c
+++ b/drivers/acpi/ac.c
@@ -36,11 +36,6 @@
static int acpi_ac_remove(struct acpi_device *device);
static void acpi_ac_notify(struct acpi_device *device, u32 event);
-struct acpi_ac_bl {
- const char *hid;
- int hrv;
-};
-
static const struct acpi_device_id ac_device_ids[] = {
{"ACPI0003", 0},
{"", 0},
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: AC: Remove the leftover struct acpi_ac_bl
2022-09-17 9:45 [PATCH] ACPI: AC: Remove the leftover struct acpi_ac_bl Hanjun Guo
@ 2022-09-17 10:39 ` Hans de Goede
2022-09-24 16:24 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2022-09-17 10:39 UTC (permalink / raw)
To: Hanjun Guo, linux-acpi; +Cc: Rafael J. Wysocki
Hi,
On 9/17/22 11:45, Hanjun Guo wrote:
> In commit 57a183222271 ("ACPI / x86: Introduce an
> acpi_quirk_skip_acpi_ac_and_battery() helper"), the usage of struct
> acpi_ac_bl was removed, but left the definition of the struct in
> the file, so remove the useless code.
>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
Good catch, thanks. Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/acpi/ac.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> index c29e41b..bb9fe79 100644
> --- a/drivers/acpi/ac.c
> +++ b/drivers/acpi/ac.c
> @@ -36,11 +36,6 @@
> static int acpi_ac_remove(struct acpi_device *device);
> static void acpi_ac_notify(struct acpi_device *device, u32 event);
>
> -struct acpi_ac_bl {
> - const char *hid;
> - int hrv;
> -};
> -
> static const struct acpi_device_id ac_device_ids[] = {
> {"ACPI0003", 0},
> {"", 0},
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ACPI: AC: Remove the leftover struct acpi_ac_bl
2022-09-17 10:39 ` Hans de Goede
@ 2022-09-24 16:24 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2022-09-24 16:24 UTC (permalink / raw)
To: Hans de Goede, Hanjun Guo; +Cc: ACPI Devel Maling List, Rafael J. Wysocki
On Sat, Sep 17, 2022 at 12:39 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> Hi,
>
> On 9/17/22 11:45, Hanjun Guo wrote:
> > In commit 57a183222271 ("ACPI / x86: Introduce an
> > acpi_quirk_skip_acpi_ac_and_battery() helper"), the usage of struct
> > acpi_ac_bl was removed, but left the definition of the struct in
> > the file, so remove the useless code.
> >
> > Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
>
> Good catch, thanks. Patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Applied as 6.1 material, thanks!
> > ---
> > drivers/acpi/ac.c | 5 -----
> > 1 file changed, 5 deletions(-)
> >
> > diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
> > index c29e41b..bb9fe79 100644
> > --- a/drivers/acpi/ac.c
> > +++ b/drivers/acpi/ac.c
> > @@ -36,11 +36,6 @@
> > static int acpi_ac_remove(struct acpi_device *device);
> > static void acpi_ac_notify(struct acpi_device *device, u32 event);
> >
> > -struct acpi_ac_bl {
> > - const char *hid;
> > - int hrv;
> > -};
> > -
> > static const struct acpi_device_id ac_device_ids[] = {
> > {"ACPI0003", 0},
> > {"", 0},
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-24 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-17 9:45 [PATCH] ACPI: AC: Remove the leftover struct acpi_ac_bl Hanjun Guo
2022-09-17 10:39 ` Hans de Goede
2022-09-24 16:24 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox