From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI Date: Mon, 29 Apr 2019 10:40:37 +0200 Message-ID: <1693119.KP9SAZBlm1@kreacher> References: <20190405142112.26592-1-yuehaibing@huawei.com> <20190426122317.GP9224@smile.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190426122317.GP9224@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Linus Walleij , Yue Haibing , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List List-Id: linux-acpi@vger.kernel.org On Friday, April 26, 2019 2:23:17 PM CEST Andy Shevchenko wrote: > On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote: > > On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing wrote: > > > > > From: YueHaibing > > > > > > When building CONFIG_ACPI is not set > > > gcc warn this: > > > > > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > > > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > > > put_device(&adev->dev); > > > ^~ > > > > > > Reported-by: Hulk Robot > > > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > > > Suggested-by: Andy Shevchenko > > > Signed-off-by: YueHaibing > > > > This doesn't apply cleanly to any GPIO branch (devel or fixes) > > so I assume it is supposed to be applied to the ACPI tree. > > Acked-by: Linus Walleij > > Thanks! > Rafael, can this be applied to your tree? Done already, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA33C43219 for ; Mon, 29 Apr 2019 08:40:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A45B7205ED for ; Mon, 29 Apr 2019 08:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727611AbfD2Ikk (ORCPT ); Mon, 29 Apr 2019 04:40:40 -0400 Received: from cloudserver094114.home.pl ([79.96.170.134]:42376 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727517AbfD2Ikj (ORCPT ); Mon, 29 Apr 2019 04:40:39 -0400 Received: from 79.184.254.69.ipv4.supernova.orange.pl (79.184.254.69) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.213) id 3f40e1ef396ec110; Mon, 29 Apr 2019 10:40:37 +0200 From: "Rafael J. Wysocki" To: Andy Shevchenko Cc: Linus Walleij , Yue Haibing , Bartosz Golaszewski , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List Subject: Re: [PATCH v3] gpio: merrifield: Fix build err without CONFIG_ACPI Date: Mon, 29 Apr 2019 10:40:37 +0200 Message-ID: <1693119.KP9SAZBlm1@kreacher> In-Reply-To: <20190426122317.GP9224@smile.fi.intel.com> References: <20190405142112.26592-1-yuehaibing@huawei.com> <20190426122317.GP9224@smile.fi.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Message-ID: <20190429084037.gdEsztZH7A2eK3HfUvxG8AcIiyVWczMnz_vgqHQuJTg@z> On Friday, April 26, 2019 2:23:17 PM CEST Andy Shevchenko wrote: > On Tue, Apr 23, 2019 at 11:17:32AM +0200, Linus Walleij wrote: > > On Fri, Apr 12, 2019 at 5:20 PM Yue Haibing wrote: > > > > > From: YueHaibing > > > > > > When building CONFIG_ACPI is not set > > > gcc warn this: > > > > > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > > > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device > > > put_device(&adev->dev); > > > ^~ > > > > > > Reported-by: Hulk Robot > > > Fixes:d00d2109c367 ("gpio: merrifield: Convert to use acpi_dev_get_first_match_dev()") > > > Suggested-by: Andy Shevchenko > > > Signed-off-by: YueHaibing > > > > This doesn't apply cleanly to any GPIO branch (devel or fixes) > > so I assume it is supposed to be applied to the ACPI tree. > > Acked-by: Linus Walleij > > Thanks! > Rafael, can this be applied to your tree? Done already, thanks!