From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [RFD][PATCH 7/7] PM / ACPI: Take device PM QoS flags into account Date: Tue, 13 Nov 2012 00:42:17 +0100 Message-ID: <1700137.RQD4zuhDgN@vostro.rjw.lan> References: <201209282351.10663.rjw@sisk.pl> <201209282356.52558.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-pci-owner@vger.kernel.org To: Bjorn Helgaas Cc: Linux PM list , ACPI Devel Mailing List , Alan Stern , Huang Ying , Sarah Sharp , Lan Tianyu , Aaron Lu , Jean Pihet , linux-pci@vger.kernel.org, Greg Kroah-Hartman , mark gross List-Id: linux-acpi@vger.kernel.org On Monday, November 12, 2012 02:07:03 PM Bjorn Helgaas wrote: > On Fri, Sep 28, 2012 at 3:56 PM, Rafael J. Wysocki wrote: > > Make ACPI power management routines and PCI power management > > routines depending on ACPI take device PM QoS flags into account > > when deciding what power state to put the device into. > > > > In particular, after this change acpi_pm_device_sleep_state() will > > not return ACPI_STATE_D3_COLD as the deepest available low-power > > state if PM_QOS_FLAG_NO_POWER_OFF is requested for the device and it > > will not require remote wakeup to work for the device in the returned > > low-power state if there is at least one PM QoS flags request for the > > device, but PM_QOS_FLAG_REMOTE_WAKEUP is not requested for it. > > > > Accordingly, acpi_pci_set_power_state() will refuse to put the > > device into D3cold if PM_QOS_FLAG_NO_POWER_OFF is requested for it. > > > > Signed-off-by: Rafael J. Wysocki > > --- > > drivers/acpi/sleep.c | 16 ++++++++++++---- > > drivers/pci/pci-acpi.c | 8 +++++++- > > This touches a file in drivers/pci, but I expect it depends on all the > previous patches in the series, so if you haven't merged it already, > Rafael, it seems like it makes sense for you to merge this instead of > me. I will, thanks a lot! Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.