From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Guenter Roeck <linux@roeck-us.net>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Vegard Nossum <vegard.nossum@gmail.com>,
Wim Van Sebroeck <wim@iguana.be>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE
Date: Thu, 24 Nov 2016 02:30:43 +0100 [thread overview]
Message-ID: <1813013.KOlSoqaZE7@vostro.rjw.lan> (raw)
In-Reply-To: <1dbc6c68-3ec7-1f4b-746d-494ffba39311@roeck-us.net>
On Monday, November 21, 2016 07:14:08 AM Guenter Roeck wrote:
> On 11/21/2016 05:33 AM, Mika Westerberg wrote:
> > The WDAT watchdog driver uses functionality provided by the watchdog timer
> > core but it did not select it explicitly. This results following linker
> > error when only WDAT_WDT is enabled in Kconfig:
> >
> > drivers/built-in.o: In function `wdat_wdt_probe':
> > drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
> >
> > Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
> > enabled.
> >
> > Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
> > Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
Applied.
Thanks,
Rafael
prev parent reply other threads:[~2016-11-24 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 13:33 [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE Mika Westerberg
2016-11-21 15:14 ` Guenter Roeck
2016-11-24 1:30 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1813013.KOlSoqaZE7@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mika.westerberg@linux.intel.com \
--cc=vegard.nossum@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox