From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Tang Chen <tangchen@cn.fujitsu.com>
Cc: lenb@kernel.org, robert.moore@intel.com, lv.zheng@intel.com,
ming.m.lin@intel.com, mpm@selenic.com,
herbert@gondor.apana.org.au, rob@landley.net,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [RESEND PATCH 1/6] acpi: Remove the leading space of "unlock" label in acpi_memory_device_notify().
Date: Tue, 26 Mar 2013 14:17:17 +0100 [thread overview]
Message-ID: <1843378.VZBEQ0WNNo@vostro.rjw.lan> (raw)
In-Reply-To: <1362558611-32255-2-git-send-email-tangchen@cn.fujitsu.com>
On Wednesday, March 06, 2013 04:30:06 PM Tang Chen wrote:
> There is a leading space in front of "unlock" label in acpi_memory_device_notify(). Remove it.
>
> Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
> ---
> drivers/acpi/acpi_memhotplug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> index da1f82b..8a10c23 100644
> --- a/drivers/acpi/acpi_memhotplug.c
> +++ b/drivers/acpi/acpi_memhotplug.c
> @@ -369,7 +369,7 @@ static void acpi_memory_device_notify(acpi_handle handle, u32 event, void *data)
> kfree(ej_event);
> }
>
> - unlock:
> +unlock:
> acpi_scan_lock_release();
> if (ACPI_SUCCESS(status))
> return;
The leading space is actually in agreement with the kernel coding style
(and there's a reason why it's there).
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-03-26 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 8:30 [RESEND PATCH 0/6] Fix some coding style and comment problems Tang Chen
2013-03-06 8:30 ` [RESEND PATCH 1/6] acpi: Remove the leading space of "unlock" label in acpi_memory_device_notify() Tang Chen
2013-03-26 13:17 ` Rafael J. Wysocki [this message]
2013-03-26 13:23 ` Richard Genoud
2013-03-26 13:50 ` Rafael J. Wysocki
2013-03-06 8:30 ` [RESEND PATCH 2/6] acpi: Add missing parameter comment for acpi_get_table_with_size() Tang Chen
2013-03-06 8:30 ` [RESEND PATCH 3/6] acpi: Remove the leading spaces of "finish_override" label in acpi_tb_table_override() Tang Chen
2013-03-06 8:30 ` [RESEND PATCH 4/6] acpi: Remove the leading spaces of "unmap_and_exit" label in acpi_tb_install_table() Tang Chen
2013-03-06 8:30 ` [RESEND PATCH 5/6] acpi: Add the missing parameter comment for acpi_initialize_tables() Tang Chen
2013-03-06 8:30 ` [RESEND PATCH 6/6] doc: Fix a wrong comment in Documentation/hw_random.txt Tang Chen
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 10:38 [RESEND PATCH 0/6] Fix some coding style and comment problems Tang Chen
2013-03-07 10:38 ` [RESEND PATCH 1/6] acpi: Remove the leading space of "unlock" label in acpi_memory_device_notify() Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1843378.VZBEQ0WNNo@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=herbert@gondor.apana.org.au \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=ming.m.lin@intel.com \
--cc=mpm@selenic.com \
--cc=rob@landley.net \
--cc=robert.moore@intel.com \
--cc=tangchen@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox