From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, James Morse <james.morse@arm.com>,
Tony Luck <tony.luck@intel.com>, Borislav Petkov <bp@alien8.de>,
Borislav Petkov <bp@suse.de>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant
Date: Mon, 26 Aug 2019 11:04:01 +0200 [thread overview]
Message-ID: <1860012.04uLkyF2MU@kreacher> (raw)
In-Reply-To: <20190717105543.76244-1-andriy.shevchenko@linux.intel.com>
On Wednesday, July 17, 2019 12:55:43 PM CEST Andy Shevchenko wrote:
> This is a missed part of the commit 5b53696a30d5
> ("ACPI / APEI: Switch to use new generic UUID API"), i.e.
> replacing old definition with a global constant variable.
>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/acpi/apei/ghes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index a66e00fe31fe..451269a2f47c 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -483,7 +483,7 @@ static void ghes_do_proc(struct ghes *ghes,
> int sev, sec_sev;
> struct acpi_hest_generic_data *gdata;
> guid_t *sec_type;
> - guid_t *fru_id = &NULL_UUID_LE;
> + const guid_t *fru_id = &guid_null;
> char *fru_text = "";
>
> sev = ghes_severity(estatus->error_severity);
>
Applied, thanks!
prev parent reply other threads:[~2019-08-26 9:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 10:55 [PATCH v1] ACPI / APEI: Get rid of NULL_UUID_LE constant Andy Shevchenko
2019-07-25 12:44 ` James Morse
2019-08-26 9:04 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1860012.04uLkyF2MU@kreacher \
--to=rjw@rjwysocki.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=hch@lst.de \
--cc=james.morse@arm.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox