From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Sinan Kaya <okaya@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Yicong Yang <yangyicong@hisilicon.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Linux PCI <linux-pci@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed
Date: Mon, 01 Jun 2020 17:22:58 +0200 [thread overview]
Message-ID: <1908398.Rfmu1g3mcC@kreacher> (raw)
In-Reply-To: <6f6aa87f-7c4d-61f6-f8c2-42ad05b5c845@kernel.org>
On Monday, June 1, 2020 5:14:45 PM CEST Sinan Kaya wrote:
> On 5/28/2020 7:42 AM, Rafael J. Wysocki wrote:
> >> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> >> index ac8ad6c..5140b26 100644
> >> --- a/drivers/acpi/pci_root.c
> >> +++ b/drivers/acpi/pci_root.c
> >> @@ -456,7 +456,7 @@ static void negotiate_os_control(struct acpi_pci_root *root, int *no_aspm,
> >>
> >> dev_info(&device->dev, "_OSC failed (%s)%s\n",
> >> acpi_format_exception(status),
> >> - pcie_aspm_support_enabled() ? "; disabling ASPM" : "");
> >> + pcie_aspm_support_enabled() ? "" : "; disabling ASPM");
> >> return;
> >> }
> >>
> >> --
> > Applied as 5.8 material under the "ACPI: PCI: Fix the ASPM part of the
> > _OSC failure message" subject and with a different changelog.
>
>
> I'm confused. The original change would print ASPM is getting disabled
> only when ASPM is supported. Now, we are printing disabling ASPM when
> ASPM is not supported.
>
> Now, we reverted the change and went back to incorrect behavior again.
>
> Am I missing something?
Well, it turns out that I was confused, as well as the author of the patch.
Dropped now, thanks for the heads-up!
next prev parent reply other threads:[~2020-06-01 15:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 8:38 [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed Yicong Yang
2020-05-28 11:42 ` Rafael J. Wysocki
2020-06-01 15:14 ` Sinan Kaya
2020-06-01 15:22 ` Rafael J. Wysocki [this message]
2020-06-02 1:57 ` Yicong Yang
2020-06-02 17:50 ` Sinan Kaya
2020-06-02 22:36 ` Bjorn Helgaas
2020-06-02 23:21 ` Sean V Kelley
2020-06-03 4:48 ` Sinan Kaya
[not found] ` <03d2a6ca-78de-2d39-5428-2949c2017099@hisilicon.com>
2020-06-03 13:02 ` [PATCH v2] ACPI: PCI: Remove ASPM text from _OSC failure message Rafael J. Wysocki
2020-06-03 13:19 ` Yicong Yang
2020-06-03 12:59 ` [PATCH] PCI/ASPM: Print correct ASPM status when _OSC failed Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1908398.Rfmu1g3mcC@kreacher \
--to=rjw@rjwysocki.net \
--cc=helgaas@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=okaya@kernel.org \
--cc=rafael@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox