From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Lv Zheng <lv.zheng@intel.com>
Cc: "Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Len Brown <len.brown@intel.com>, Lv Zheng <zetalog@gmail.com>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Stable # all applicable <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] ACPI: EC: Drop EC noirq hooks to fix a regression
Date: Wed, 12 Jul 2017 23:17:53 +0200 [thread overview]
Message-ID: <1959612.ejQZU5VTTY@aspire.rjw.lan> (raw)
In-Reply-To: <26498770711bbb36ca2888b33b56a0a56dc29083.1499828705.git.lv.zheng@intel.com>
On Wednesday, July 12, 2017 11:09:09 AM Lv Zheng wrote:
> According to the bug report, though the busy polling mode can make noirq
> stages executed faster, it causes abnormal fan blowing up after a system
> resume (see link #1 for a video demonstration) on Lenovo ThinkPad X1 Carbon
> - the 5th Generation. The problem can be fixed by an upgraded EC firmware.
>
> However many reporters can also confirm that the problem can be fixed by
> stopping busy polling during suspend/resume.
>
> This patch drops noirq stage hooks so that the regression can be fixed
> without upgrading the EC firmware.
>
> Fixes: c3a696b6e8f8 ("ACPI / EC: Use busy polling mode when GPE is not enabled")
> Link: https://youtu.be/9NQ9x-Jm99Q [#1]
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=196129
> Reported-by: Andreas Lindhe <andreas@lindhe.io>
> Tested-by: Gjorgji Jankovski <j.gjorgji@gmail.com>
> Tested-by: Damjan Georgievski <gdamjan@gmail.com>
> Tested-by: Fernando Chaves <nanochaves@gmail.com>
> Tested-by: Tomislav Ivek <tomislav.ivek@gmail.com>
> Tested-by: Denis P. <theoriginal.skullburner@gmail.com>
> Signed-off-by: Lv Zheng <lv.zheng@intel.com>
> Cc: Stable <stable@vger.kernel.org> # all applicable
Both patches applied with some minor modifications in the changelogs.
Thanks,
Rafael
prev parent reply other threads:[~2017-07-12 21:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 3:09 [PATCH 1/2] ACPI: EC: Drop EC noirq hooks to fix a regression Lv Zheng
2017-07-12 3:09 ` [PATCH 2/2] ACPI: EC: Revert "ACPI / EC: Enable event freeze mode..." " Lv Zheng
2017-07-12 21:17 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1959612.ejQZU5VTTY@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=stable@vger.kernel.org \
--cc=zetalog@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).