Re: [PATCH 0/3] Generic sysfs support for ACPI ALS and other ALS devices

Pavel Machek
2009-08-04T13:21:37Z

On Mon 2009-08-03 17:10:57, Zhang Rui wrote:
> Hi, all,
>
> This is the patch set I made to introduce ACPI ALS device driver
> and a generic sysfs I/F for all the ALS devices, like ACPI ALS,
> platform ALS, etc.
>
> Patch 01 introduces the ACPI ALS device driver.
>
> Patch 02 introduces ALS sysfs class.
> Two sysfs I/F are created for each ALS device.
> /sys/class/als/alsX/illuminance:
> the amount of light incident upon a specified surface area.
> /sys/class/als/alsX/mappings:
> ambient light illuminance to display luminance mappings
> that can be used by an OS to calibrate its ambient light policy
> this is what I got on a test box:
> cat /sys/class/als/als0/mappings
> ???Illuminance Adjustment
> 0 70
> 10 73
> 80 85
> 300 100
> 1000 150

There's one value per file for sysfs... You should definitely have the
header.

Is there chance to already return adjusted values, avoiding this
uglyness?

Plus I'd say Documentation/ file is needed.

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html