From: "Vegard Nossum" <vegard.nossum@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Len Brown <lenb@kernel.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
Zhao Yakui <yakui.zhao@intel.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Alexey Starikovskiy <astarikovskiy@suse.de>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>
Subject: Re: [PATCH] ACPI: don't walk tables if ACPI was disabled
Date: Tue, 24 Jun 2008 13:52:55 +0200 [thread overview]
Message-ID: <19f34abd0806240452w2561040uc2b1b1d35562db71@mail.gmail.com> (raw)
In-Reply-To: <20080624114139.GC21890@elte.hu>
On 6/24/08, Ingo Molnar <mingo@elte.hu> wrote:
> i havent seen the warning reappear with your fix after thousands of
> bootups - so i guess we can consider it fixed.
>
> Len, please consider the patch below. (it's in tip/out-of-tree)
No, please don't :-)
It fixes your particular case (the acpi_rtc_init() hunk of the patch),
but the acpi_walk_namespace() part should be changed to a WARN(). But
that is likely to cause a lot of "spurious" reports, so the other acpi
drivers should be fixed as well.
I was waiting for Len to reply, but maybe I can submit the proper fix too.
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
next prev parent reply other threads:[~2008-06-24 11:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 9:52 [bug, acpi] BUG: spinlock bad magic on CPU#0, swapper/1, ACPI Exception (utmutex-0263): AE_BAD_PARAMETER Ingo Molnar
2008-06-20 13:11 ` Vegard Nossum
2008-06-20 13:56 ` [PATCH] ACPI: don't walk tables if ACPI was disabled Vegard Nossum
2008-06-20 14:22 ` Ingo Molnar
2008-06-25 2:34 ` [PATCH] ACPI: add standard linux WARN() output to ACPI warnings Len Brown
2008-06-25 2:49 ` Arjan van de Ven
2008-06-25 3:10 ` Len Brown
2008-06-26 3:57 ` Len Brown
2008-06-20 19:00 ` [PATCH] ACPI: don't walk tables if ACPI was disabled Len Brown
2008-06-20 20:40 ` Vegard Nossum
2008-06-20 21:27 ` Vegard Nossum
2008-06-21 8:19 ` Vegard Nossum
2008-06-24 11:41 ` Ingo Molnar
2008-06-24 11:52 ` Vegard Nossum [this message]
2008-06-24 15:22 ` Bjorn Helgaas
2008-06-25 1:37 ` Zhao Yakui
2008-06-25 15:08 ` Bjorn Helgaas
2008-06-26 3:02 ` Zhao Yakui
2008-06-26 16:44 ` Bjorn Helgaas
2008-06-25 2:41 ` Len Brown
2008-06-25 7:07 ` Ingo Molnar
2008-06-25 3:07 ` Len Brown
2008-06-25 3:07 ` [PATCH 1/4] ACPI: add standard linux WARN() output to ACPI warnings Len Brown
2008-06-25 3:07 ` [PATCH 2/4] ACPI: add WARN_ON(acpi_disabled) Len Brown
2008-06-25 3:07 ` [PATCH 3/4] dock: bay: Don't call acpi_walk_namespace() when ACPI is disabled Len Brown
2008-06-25 3:07 ` [PATCH 4/4] ACPI: don't walk tables if ACPI was disabled Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19f34abd0806240452w2561040uc2b1b1d35562db71@mail.gmail.com \
--to=vegard.nossum@gmail.com \
--cc=astarikovskiy@suse.de \
--cc=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rjw@sisk.pl \
--cc=yakui.zhao@intel.com \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox