public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
	ACPI Devel Mailing List <linux-acpi@vger.kernel.org>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: ACPI scan regression -> Boot fail on Cherrytrail w/ 5.11-rc3
Date: Thu, 14 Jan 2021 18:49:17 -0600	[thread overview]
Message-ID: <1bb7f766-4f29-55b1-882c-3d70cca0912f@linux.intel.com> (raw)
In-Reply-To: <f5dae2aa-ffcb-1af1-726f-2362cb4fe470@redhat.com>

Thanks Hans for your reply, much appreciated.

> Pierre-Louis, can you see if the following hack helps? :
> 
> --- a/drivers/acpi/scan.c
> +++ b/drivers/acpi/scan.c
> @@ -1939,7 +1939,6 @@ static acpi_status acpi_bus_check_add(acpi_handle handle, bool check_dep,
>   		/* Bail out if the number of recorded dependencies is not 0. */
>   		if (count > 0) {
>   			acpi_bus_scan_second_pass = true;
> -			return AE_CTRL_DEPTH;
>   		}
>   	}
>   
> @@ -1948,8 +1947,7 @@ static acpi_status acpi_bus_check_add(acpi_handle handle, bool check_dep,
>   		return AE_CTRL_DEPTH;
>   
>   	acpi_scan_init_hotplug(device);
> -	if (!check_dep)
> -		acpi_scan_dep_init(device);
> +	acpi_scan_dep_init(device);
>   
>   out:
>   	if (!*adev_p)

Yep, those 'hacks' solve the boot problem on my device. I tried multiple 
times and it's completely reproducible.

> And can you collect an acpidump from the device and either send it to me and Rafael
> offlist, or upload it somewhere and send us a link ?

will do


  reply	other threads:[~2021-01-15  0:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-14 21:55 ACPI scan regression -> Boot fail on Cherrytrail w/ 5.11-rc3 Pierre-Louis Bossart
2021-01-14 23:34 ` Hans de Goede
2021-01-15  0:49   ` Pierre-Louis Bossart [this message]
2021-01-15  8:54     ` Hans de Goede
2021-01-15 13:38       ` Rafael J. Wysocki
2021-01-15 13:54     ` Rafael J. Wysocki
2021-01-15 14:52       ` Pierre-Louis Bossart
2021-01-15 14:55         ` Rafael J. Wysocki
2021-01-15 15:09           ` Pierre-Louis Bossart
2021-01-15 15:22             ` Rafael J. Wysocki
2021-01-15 15:38               ` Pierre-Louis Bossart
2021-01-15 16:05                 ` Hans de Goede
2021-01-15 16:22                   ` Rafael J. Wysocki
2021-01-15 16:41                     ` Pierre-Louis Bossart
2021-01-15 19:01                       ` Rafael J. Wysocki
2021-01-15 19:06                         ` Rafael J. Wysocki
2021-01-15 20:48                         ` Hans de Goede
2021-01-15 21:57                         ` Hans de Goede
     [not found]                           ` <56b732f4-9a24-688e-7cc7-6c2522d173c9@linux.intel.com>
2021-01-16 11:18                             ` Hans de Goede
2021-01-16 12:26                           ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1bb7f766-4f29-55b1-882c-3d70cca0912f@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox