Re: [PATCH 06/18] platform/x86: acer-wmi: Use devm_platform_profile_register()

Mario Limonciello
2025-01-09T16:36:27Z

On 1/9/2025 09:06, Kurt Borja wrote:
> Replace platform_profile_register() with it's device managed version.
>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/platform/x86/acer-wmi.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 585d54d8d80c..70ec667e0cbf 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -1928,7 +1928,7 @@ static int acer_platform_profile_setup(struct platform_device *device)
> platform_profile_handler.ops =
> &acer_predator_v4_platform_profile_ops;
>
> - err = platform_profile_register(&platform_profile_handler, NULL);
> + err = devm_platform_profile_register(&platform_profile_handler, NULL);
> if (err)
> return err;
>
> @@ -2575,8 +2575,6 @@ static int acer_platform_probe(struct platform_device *device)
> return 0;
>
> error_hwmon:
> - if (platform_profile_support)
> - platform_profile_remove(&platform_profile_handler);
> error_platform_profile:
> acer_rfkill_exit();
> error_rfkill:
> @@ -2597,9 +2595,6 @@ static void acer_platform_remove(struct platform_device *device)
> acer_backlight_exit();
>
> acer_rfkill_exit();
> -
> - if (platform_profile_support)
> - platform_profile_remove(&platform_profile_handler);
> }
>
> #ifdef CONFIG_PM_SLEEP