From mboxrd@z Thu Jan 1 00:00:00 1970 From: Juergen Gross Subject: Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid Date: Tue, 13 Feb 2018 17:48:43 +0100 Message-ID: <1d6083f2-0a3e-2f3a-7089-426f81e8af93@suse.com> References: <20180116135730.19216-1-jgross@suse.com> <20180116154630.ke53suvokynj73qd@gmail.com> <432c21ab-24d8-1e70-a471-ad8a14357d4e@suse.com> <20180116163529.rc5j23oqmwk45rp5@gmail.com> <4a8b0233-9bb8-3c95-0a08-93a5ceffc231@suse.com> <20180117153404.qnv3tjf6jhk4xijs@gmail.com> <20180213163244.j2zuxyhs4kbfhwgj@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mx2.suse.de ([195.135.220.15]:40314 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934060AbeBMQsq (ORCPT ); Tue, 13 Feb 2018 11:48:46 -0500 In-Reply-To: <20180213163244.j2zuxyhs4kbfhwgj@gmail.com> Content-Language: de-DE Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Ingo Molnar , "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, x86@kernel.org, lenb@kernel.org, rafael.j.wysocki@intel.com, tglx@linutronix.de, mingo@redhat.com On 13/02/18 17:32, Ingo Molnar wrote: > > * Juergen Gross wrote: > >> So what about the following: >> >> From version 0x020e on (current version without my patches is 0x020d) >> the boot loader will write its supported version or'ed with 0x8000 into >> the same version field. So we can be sure any added fields are filled >> with real data or the information has been evaluated by the boot loader, >> if the returned version included that field. If the boot loader finds >> the kernel supports a version < 0x020e it won't return its supported >> version. > > This seems like a usable workaround to me, as long as everyone involved > agrees with it. Okay, thanks for the feedback. I'll go that route. > I've removed the patches for the time being. Seems a sensible thing to do. Juergen