ACPI: compilation fixes

public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed

* ACPI: compilation fixes
@ 2002-08-01 10:40 Pavel Machek
       [not found] ` <20020801104053.GA137-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Pavel Machek @ 2002-08-01 10:40 UTC (permalink / raw)
  To: Andrew Grover, ACPI mailing list, kernel list

Hi!

2.5.29 will not compile for me without these, please apply.

								Pavel
--- clean/drivers/acpi/system.c	Mon Jul 29 20:02:23 2002
+++ linux-swsusp/drivers/acpi/system.c	Mon Jul 29 20:14:27 2002
@@ -256,7 +256,8 @@
 	acpi_status		status = AE_ERROR;
 	unsigned long		flags = 0;
 
-	save_flags(flags);
+	local_irq_save(flags);
+	local_irq_disable();
 	
 	switch (state)
 	{
@@ -270,7 +271,7 @@
 		do_suspend_lowlevel(0);
 		break;
 	}
-	restore_flags(flags);
+	local_irq_restore(flags);
 
 	return status;
 }

-- 
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 2+ messages in thread

[parent not found: <20020801104053.GA137-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>]

* Re: ACPI: compilation fixes
       [not found] ` <20020801104053.GA137-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
@ 2002-08-01 13:43   ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2002-08-01 13:43 UTC (permalink / raw)
  To: Pavel Machek; +Cc: Andrew Grover, ACPI mailing list, kernel list

On Thu, Aug 01, 2002 at 12:40:53PM +0200, Pavel Machek wrote:
> -	save_flags(flags);
> +	local_irq_save(flags);
> +	local_irq_disable();

umm.  local_irq_save disables interrupts:

#define local_irq_save(x)       __asm__ __volatile__("pushfl ; popl %0 ; cli":"=
g" (x): /* no input */ :"memory")

i think you're confused with local_save_flags.

-- 
Revolutions do not require corporate support.


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2002-08-01 13:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-08-01 10:40 ACPI: compilation fixes Pavel Machek
     [not found] ` <20020801104053.GA137-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2002-08-01 13:43   ` Matthew Wilcox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox