patch: acpi-20020821 fix?

patch: acpi-20020821 fix?

[Giridhar Pemmasani]

It seems that the following patch against drivers/acpi/system.c
is needed to get 'echo -n 5 > /proc/acpi/sleep' to work as
expected. 

--- system.c.orig   Tue Aug 27 02:42:17 2002
+++ system.c    Tue Aug 27 02:43:42 2002
@@ -110,7 +110,7 @@
    acpi_status status;
 
    /* only support S1 and S5 on kernel 2.4 */
-   if (state != ACPI_STATE_S1 || state != ACPI_STATE_S5)
+   if (state != ACPI_STATE_S1 && state != ACPI_STATE_S5)
        return AE_ERROR;
 
    acpi_enter_sleep_state_prep(state);


-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone?  Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390

Re: patch: acpi-20020821 fix?

[valvo]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Tue, Aug 27, 2002 at 02:55:25AM -0400, Giridhar Pemmasani wrote:

> It seems that the following patch against drivers/acpi/system.c
> is needed to get 'echo -n 5 > /proc/acpi/sleep' to work as
> expected. 
> 
> --- system.c.orig   Tue Aug 27 02:42:17 2002
> +++ system.c    Tue Aug 27 02:43:42 2002
> @@ -110,7 +110,7 @@
>     acpi_status status;
>  
>     /* only support S1 and S5 on kernel 2.4 */
> -   if (state != ACPI_STATE_S1 || state != ACPI_STATE_S5)
> +   if (state != ACPI_STATE_S1 && state != ACPI_STATE_S5)
>         return AE_ERROR;
>  
>     acpi_enter_sleep_state_prep(state);
> 

i don't understand the purpouses of this patch...can you be more explicit, plz ?

-- 
[ valvoline :: VRL Team :: s0ftpj :: freaknet Medialab :: GPG key available  ]
[ key fingerprint :: - :: B7E2 48BC 705F AE8F 9ABE  E422 076A 2561 1D67 B4DD ]
[ GPG key available on keyserver :: pgp.mit.edu :: with keyID :: 1D67B4DD :: ]

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

Re: patch: acpi-20020821 fix?

[Matthew Wilcox]

On Thu, Aug 29, 2002 at 04:44:34PM +0200, valvo wrote:
> On Tue, Aug 27, 2002 at 02:55:25AM -0400, Giridhar Pemmasani wrote:
> > -   if (state != ACPI_STATE_S1 || state != ACPI_STATE_S5)
> > +   if (state != ACPI_STATE_S1 && state != ACPI_STATE_S5)

> i don't understand the purpouses of this patch...can you be more explicit, plz ?

think about it... we have:

	if (x != a || z != b)

this is _always_ true.  if x == a then x != b and thus the test always passes
so we return an error.  it's a simple & easy mistake to make.

-- 
Revolutions do not require corporate support.


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: patch: acpi-20020821 fix?

[Ville Syrjälä]

On Thu, Aug 29, 2002 at 04:44:34PM +0200, valvo wrote:
> On Tue, Aug 27, 2002 at 02:55:25AM -0400, Giridhar Pemmasani wrote:
> >     /* only support S1 and S5 on kernel 2.4 */
> > -   if (state != ACPI_STATE_S1 || state != ACPI_STATE_S5)
> > +   if (state != ACPI_STATE_S1 && state != ACPI_STATE_S5)
> >         return AE_ERROR;
>
> i don't understand the purpouses of this patch...can you be more explicit, plz ?

Looks clear to me. Without this change the condition is always true.

-- 
Ville Syrjälä
syrjala-ORSVBvAovxo@public.gmane.org
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: patch: acpi-20020821 fix?

[valvo]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On Thu, Aug 29, 2002 at 06:20:33PM +0300, Ville Syrj?l? wrote:

> Looks clear to me. Without this change the condition is always true.

sorry!. now it's clear! (=
btw, a common mistake....

-- 
[ valvoline :: VRL Team :: s0ftpj :: freaknet Medialab :: GPG key available  ]
[ key fingerprint :: - :: B7E2 48BC 705F AE8F 9ABE  E422 076A 2561 1D67 B4DD ]
[ GPG key available on keyserver :: pgp.mit.edu :: with keyID :: 1D67B4DD :: ]

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]