Re: Thermal managment broken

Pavel Machek
2002-09-18T10:25:55Z

Hi!

> > First is strict bugfix, please take. Second is needed, please take it,
> > too.
> While I'd "vote" for the second patch "in general", there are two aspects
> which should be mentioned first:
>
>
> > + tz->trips.critical.temperature = CELSIUS_TO_KELVIN(critical);
> > + tz->trips.hot.temperature = CELSIUS_TO_KELVIN(hot);
> > + tz->trips.passive.temperature = CELSIUS_TO_KELVIN(passive);
> > + tz->trips.active[0].temperature = CELSIUS_TO_KELVIN(active0);
> > + tz->trips.active[1].temperature = CELSIUS_TO_KELVIN(active1);
>
> You explicitely want to support _two_ active trip points here. While this
> seems to be the amount of active trip points seen on most systems, I'd
> prefer you'd do a more flexible interface [zero to ACPI_THERMAL_MAX_ACTIVE
> would be best].

Okay.

[Andrew, do you want to take this one and then followup which adds
many active points, or do you want whole new patch?]

> Additionally, it might be better to specify a "starting" and
> "stopping" trip point - so that you don't have a fan going
> on-off-on-off-on-off repeatedly. (IIRC someone complained about this a few
> months ago on this list). But even without this "feature", I'd like to see
> the user-specified trip points in the acpi patch.

I believe this is orthogonal. You need to do two thresholds even
without user help, so it needs to be solved some other way.

Pavel
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.

-------------------------------------------------------
This SF.NET email is sponsored by: AMD - Your access to the experts
on Hammer Technology! Open Source & Linux Developers, register now
for the AMD Developer Symposium. Code: EX8664