public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
* problem dumping/fixing dsdt
@ 2002-09-22 10:29 joerg.beyer-htSm2yLGOjU
       [not found] ` <200209221029.g8MATCX10556-pb599fR3TxVkExQqqHjIK3sFFmKitW5W@public.gmane.org>
  0 siblings, 1 reply; 4+ messages in thread
From: joerg.beyer-htSm2yLGOjU @ 2002-09-22 10:29 UTC (permalink / raw)
  To: acpilist

Hi,

I tried to fix my dsdt, but it _think_, that acpidump
does not handle my table well. I get a very short table,
as you can see below. Since I dont have experience with
stuff like this, I would like to ask, if the below
results are expected.

    yours
    Joerg


wally:/usr/src/pacpidump/pacpidump # ./acpidump >dsdt.asl
acpidump: DSDT is corrupt

wally:/usr/src/pacpidump/pacpidump # cat dstdt.asl
/*
RSD PTR: Checksum=173, OEMID=PTLTD, RsdtAddress=0x0effbfc0
 */
/*
RSDT: Length=40, Revision=1, Checksum=135,
    OEMID=PTLTD, OEM Table ID=  RSDT, OEM Revision=0x6040000,
    Creator ID= LTP, Creator Revision=0x0
 */
/*
    Entries={ 0x0efffb8c }
 */
/*
    DSDT=0xeffbfe8
    INT_MODEL=PIC
    SCI_INT=9
    SMI_CMD=0x802f, ACPI_ENABLE=0xf0, ACPI_DISABLE=0xf1, S4BIOS_REQ=0xf2
    PM1a_EVT_BLK=0x8000-0x8003
    PM1a_CNT_BLK=0x8004-0x8005
    PM2_TMR_BLK=0x8008-0x800b
    PM2_GPE0_BLK=0x8020-0x8023
    P_LVL2_LAT=90ms, P_LVL3_LAT=1900ms
    FLUSH_SIZE=0, FLUSH_STRIDE=0
    DUTY_OFFSET=0, DUTY_WIDTH=4
    DAY_ALRM=125, MON_ALRM=126, CENTURY=50
    Flags={WBINVD,PROC_C1,SLP_BUTTON,RTC_S4}
 */
wally:/usr/src/pacpidump/pacpidump # iasl -tc dsdt.asl

Intel ACPI Component Architecture
ASL Optimizing Compiler / AML Disassembler version 20020829 [Aug 29 2002]
Copyright (C) 2000 - 2002 Intel Corporation
Supports ACPI Specification Revision 2.0a

dsdt.asl    27:
Error    1037 -^ parse error, expecting `error' or `PARSEOP_DEFINITIONBLOCK'

ASL Input:  dsdt.asl - 27 lines, 652 bytes, 0 keywords
Compilation complete. 1 Errors, 0 Warnings, 0 Remarks, 0 Optimizations



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: problem dumping/fixing dsdt
@ 2002-09-25 19:48 joerg.beyer-htSm2yLGOjU
  0 siblings, 0 replies; 4+ messages in thread
From: joerg.beyer-htSm2yLGOjU @ 2002-09-25 19:48 UTC (permalink / raw)
  Cc: acpi-devel

On Tue, Sep 24, 2002 at 03:32:02AM -0400, Sérgio Monteiro Basto wrote:

First of all: Thanks a lot!

I did as you suggested and it works great - with a single exception.
Thinks work, that never did before:
- I could adjust the brightness of the display
- I now have events when the power cord is plugged in/out

What I miss (and what worked before) is the state of the battery (yes, it
is compiled in the kernel). The whole /proc/acpi/battery directory
is missing. I asume that this is connected to the two warnings I go
while I compiled the dsdt.dsl, is this right?

> I had the same problem with acpidump
> you can use pmtools from intel acpi site
>
> http://developer.intel.com/technology/iapc/acpi/downloads/pmtools-20010730.tar.gz
> and get last (binary) iasl from same location .
>
> tar xzvf pmtools-20010730.tar.gz
> cd pmtools-20010730
> make
> cd acpidmp
> ./acpidmp DSDT > dsdt           (as root!)
> ./iasl  -d dsdt
> correct dsdt.dsl
> ./iasl -tc -i dsdt.dsl
Here I got 2 warnings:

Intel ACPI Component Architecture
ASL Optimizing Compiler / AML Disassembler version 20020829 [Aug 29 2002]
Copyright (C) 2000 - 2002 Intel Corporation
Supports ACPI Specification Revision 2.0a

dsdt.dsl    25:             Method (_PSS, 0, NotSerialized)
Warning  2019 -                        ^ Mixed return types in method (_PSS)

dsdt.dsl    25:             Method (_PSS, 0, NotSerialized)
Warning  2026 -                        ^ Reserved method must return a value (_PSS)

ASL Input:  dsdt.dsl - 3171 lines, 105560 bytes, 1489 keywords
AML Output: DSDT.aml - 14049 bytes 420 named objects 1069 executable opcodes

Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 335 Optimizations

My dsdt.dsl is 3170 lines long, here is, what seems to be the relevant part
(dsdt.dsl    25:... means: file "dsdt.dsl", line 25, right?)
I added line numbers for reference

     1  /*
     2   * Intel ACPI Component Architecture
     3   * AML Disassembler version 20020829
     4   *
     5   * Disassembly of dsdt, Wed Sep 25 20:33:14 2002
     6   */
     7  DefinitionBlock ("DSDT.aml", "DSDT", 1, "VIA  ", "PTL_ACPI", 100925440)
     8  {
     9      Scope (\_PR)
    10      {
    11          Processor (CPU0, 0x01, 0x00008010, 0x06)
    12          {
    13              Name (_PCT, Package (0x02)
    14              {
    15                  ResourceTemplate ()
    16                  {
    17                      Register (FFixedHW, 0x00, 0x00, 0x0000000000000000)
    18                  },
    19
    20                  ResourceTemplate ()
    21                  {
    22                      Register (FFixedHW, 0x00, 0x00, 0x0000000000000000)
    23                  }
    24              })
    25              Method (_PSS, 0, NotSerialized)
    26              {
    27                  Store (MFID, Local0)
    28                  Store (MVID, Local1)
    29                  If (LEqual (Local0, 0x0A))
    30                  {
    31                      If (LEqual (Local1, 0x0C))
    32                      {
    33                          Return (Z000)
    34                      }
    35                  }
    36
    37                  If (LEqual (Local0, 0x0B))
    38                  {
    39                      If (LEqual (Local1, 0x0C))
    40                      {
    41                          Return (Z001)
    42                      }
    43                  }
    44
    45                  If (LEqual (Local0, 0x0C))
    46                  {
    47                      If (LEqual (Local1, 0x0C))
    48                      {
    49                          Return (Z002)
    50                      }
    51                  }
    52
    53                  If (LEqual (Local0, 0x0D))
    54                  {
    55                      If (LEqual (Local1, 0x0C))
    56                      {
    57                          Return (Z003)
    58                      }
    59                  }
    60
    61                  If (LEqual (Local0, 0x0E))
    62                  {
    63                      If (LEqual (Local1, 0x0C))
    64                      {
    65                          Return (Z004)
    66                      }
    67                  }
    68
    69                  If (LEqual (Local0, 0x00))
    70                  {
    71                      If (LEqual (Local1, 0x0C))
    72                      {
    73                          Return (Z005)
    74                      }
    75                  }
    76
    77                  If (LEqual (Local0, 0x02))
    78                  {
    79                      If (LEqual (Local1, 0x0D))
    80                      {
    81                          Return (Z006)
    82                      }
    83                  }
    84
    85                  If (LEqual (Local0, 0x0A))
    86                  {
    87                      If (LEqual (Local1, 0x0A))
    88                      {
    89                          Return (Z007)
    90                      }
    91                  }
    92
    93                  If (LEqual (Local0, 0x0B))
    94                  {
    95                      If (LEqual (Local1, 0x0A))
    96                      {
    97                          Return (Z008)
    98                      }
    99                  }
   100
   101                  If (LEqual (Local0, 0x0C))
   102                  {
   103                      If (LEqual (Local1, 0x0B))
   104                      {
   105                          Return (Z009)
   106                      }
   107                  }
   108
   109                  If (LEqual (Local0, 0x0D))
   110                  {
   111                      If (LEqual (Local1, 0x0B))
   112                      {
   113                          Return (Z00A)
   114                      }
   115                  }
   116
   117                  If (LEqual (Local0, 0x02))
   118                  {
   119                      If (LEqual (Local1, 0x09))
   120                      {
   121                          Return (Z00B)
   122                      }
   123                  }
   124              }
   125
   126              Name (Z000, Package (0x02)
   127              {
   128                  Package (0x06)
   129                  {
   130                      0x0320,
   131                      0x5DC0,
   132                      0x7D,
   133                      0x7D,
   134                      0x009C418A,
   135                      0x018A
   136                  },
   137
   138                  Package (0x06)
   139                  {
   140                      0x01F4,
   141                      0x3896,
   142                      0x7D,
   143                      0x7D,
   144                      0x009C41C4,
   145                      0x01C4
   146                  }
   147              })
   148              Name (Z001, Package (0x02)
   149              {
   150                  Package (0x06)


could you suggest any fix?

    TIA
    Joerg




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 4+ messages in thread
* RE: problem dumping/fixing dsdt
@ 2002-09-25 21:11 Moore, Robert
  0 siblings, 0 replies; 4+ messages in thread
From: Moore, Robert @ 2002-09-25 21:11 UTC (permalink / raw)
  To: 'joerg.beyer=htSm2yLGOjU@public.gmane.org',
	SérgioMonteiroBasto
  Cc: acpi-devel


You need to add a return statement (with a value) at the end of the method.
Bob


-----Original Message-----
From: joerg.beyer-htSm2yLGOjU@public.gmane.org [mailto:joerg.beyer@email.de] 
Sent: Wednesday, September 25, 2002 12:48 PM
To: SérgioMonteiroBasto
Cc: acpi-devel
Subject: Re: [ACPI] problem dumping/fixing dsdt

On Tue, Sep 24, 2002 at 03:32:02AM -0400, Sérgio Monteiro Basto wrote:

First of all: Thanks a lot!

I did as you suggested and it works great - with a single exception.
Thinks work, that never did before:
- I could adjust the brightness of the display
- I now have events when the power cord is plugged in/out

What I miss (and what worked before) is the state of the battery (yes, it
is compiled in the kernel). The whole /proc/acpi/battery directory
is missing. I asume that this is connected to the two warnings I go
while I compiled the dsdt.dsl, is this right?

> I had the same problem with acpidump
> you can use pmtools from intel acpi site
>
>
http://developer.intel.com/technology/iapc/acpi/downloads/pmtools-20010730.t
ar.gz
> and get last (binary) iasl from same location .
>
> tar xzvf pmtools-20010730.tar.gz
> cd pmtools-20010730
> make
> cd acpidmp
> ./acpidmp DSDT > dsdt           (as root!)
> ./iasl  -d dsdt
> correct dsdt.dsl
> ./iasl -tc -i dsdt.dsl
Here I got 2 warnings:

Intel ACPI Component Architecture
ASL Optimizing Compiler / AML Disassembler version 20020829 [Aug 29 2002]
Copyright (C) 2000 - 2002 Intel Corporation
Supports ACPI Specification Revision 2.0a

dsdt.dsl    25:             Method (_PSS, 0, NotSerialized)
Warning  2019 -                        ^ Mixed return types in method (_PSS)

dsdt.dsl    25:             Method (_PSS, 0, NotSerialized)
Warning  2026 -                        ^ Reserved method must return a value
(_PSS)

ASL Input:  dsdt.dsl - 3171 lines, 105560 bytes, 1489 keywords
AML Output: DSDT.aml - 14049 bytes 420 named objects 1069 executable opcodes

Compilation complete. 0 Errors, 2 Warnings, 0 Remarks, 335 Optimizations

My dsdt.dsl is 3170 lines long, here is, what seems to be the relevant part
(dsdt.dsl    25:... means: file "dsdt.dsl", line 25, right?)
I added line numbers for reference

     1  /*
     2   * Intel ACPI Component Architecture
     3   * AML Disassembler version 20020829
     4   *
     5   * Disassembly of dsdt, Wed Sep 25 20:33:14 2002
     6   */
     7  DefinitionBlock ("DSDT.aml", "DSDT", 1, "VIA  ", "PTL_ACPI",
100925440)
     8  {
     9      Scope (\_PR)
    10      {
    11          Processor (CPU0, 0x01, 0x00008010, 0x06)
    12          {
    13              Name (_PCT, Package (0x02)
    14              {
    15                  ResourceTemplate ()
    16                  {
    17                      Register (FFixedHW, 0x00, 0x00,
0x0000000000000000)
    18                  },
    19
    20                  ResourceTemplate ()
    21                  {
    22                      Register (FFixedHW, 0x00, 0x00,
0x0000000000000000)
    23                  }
    24              })
    25              Method (_PSS, 0, NotSerialized)
    26              {
    27                  Store (MFID, Local0)
    28                  Store (MVID, Local1)
    29                  If (LEqual (Local0, 0x0A))
    30                  {
    31                      If (LEqual (Local1, 0x0C))
    32                      {
    33                          Return (Z000)
    34                      }
    35                  }
    36
    37                  If (LEqual (Local0, 0x0B))
    38                  {
    39                      If (LEqual (Local1, 0x0C))
    40                      {
    41                          Return (Z001)
    42                      }
    43                  }
    44
    45                  If (LEqual (Local0, 0x0C))
    46                  {
    47                      If (LEqual (Local1, 0x0C))
    48                      {
    49                          Return (Z002)
    50                      }
    51                  }
    52
    53                  If (LEqual (Local0, 0x0D))
    54                  {
    55                      If (LEqual (Local1, 0x0C))
    56                      {
    57                          Return (Z003)
    58                      }
    59                  }
    60
    61                  If (LEqual (Local0, 0x0E))
    62                  {
    63                      If (LEqual (Local1, 0x0C))
    64                      {
    65                          Return (Z004)
    66                      }
    67                  }
    68
    69                  If (LEqual (Local0, 0x00))
    70                  {
    71                      If (LEqual (Local1, 0x0C))
    72                      {
    73                          Return (Z005)
    74                      }
    75                  }
    76
    77                  If (LEqual (Local0, 0x02))
    78                  {
    79                      If (LEqual (Local1, 0x0D))
    80                      {
    81                          Return (Z006)
    82                      }
    83                  }
    84
    85                  If (LEqual (Local0, 0x0A))
    86                  {
    87                      If (LEqual (Local1, 0x0A))
    88                      {
    89                          Return (Z007)
    90                      }
    91                  }
    92
    93                  If (LEqual (Local0, 0x0B))
    94                  {
    95                      If (LEqual (Local1, 0x0A))
    96                      {
    97                          Return (Z008)
    98                      }
    99                  }
   100
   101                  If (LEqual (Local0, 0x0C))
   102                  {
   103                      If (LEqual (Local1, 0x0B))
   104                      {
   105                          Return (Z009)
   106                      }
   107                  }
   108
   109                  If (LEqual (Local0, 0x0D))
   110                  {
   111                      If (LEqual (Local1, 0x0B))
   112                      {
   113                          Return (Z00A)
   114                      }
   115                  }
   116
   117                  If (LEqual (Local0, 0x02))
   118                  {
   119                      If (LEqual (Local1, 0x09))
   120                      {
   121                          Return (Z00B)
   122                      }
   123                  }
   124              }
   125
   126              Name (Z000, Package (0x02)
   127              {
   128                  Package (0x06)
   129                  {
   130                      0x0320,
   131                      0x5DC0,
   132                      0x7D,
   133                      0x7D,
   134                      0x009C418A,
   135                      0x018A
   136                  },
   137
   138                  Package (0x06)
   139                  {
   140                      0x01F4,
   141                      0x3896,
   142                      0x7D,
   143                      0x7D,
   144                      0x009C41C4,
   145                      0x01C4
   146                  }
   147              })
   148              Name (Z001, Package (0x02)
   149              {
   150                  Package (0x06)


could you suggest any fix?

    TIA
    Joerg




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Acpi-devel mailing list
Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-09-25 21:11 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-09-22 10:29 problem dumping/fixing dsdt joerg.beyer-htSm2yLGOjU
     [not found] ` <200209221029.g8MATCX10556-pb599fR3TxVkExQqqHjIK3sFFmKitW5W@public.gmane.org>
2002-09-24  7:32   ` Sérgio Monteiro Basto
  -- strict thread matches above, loose matches on Subject: below --
2002-09-25 19:48 joerg.beyer-htSm2yLGOjU
2002-09-25 21:11 Moore, Robert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox