Sleeping pills for the 2.5.39 Insomnia ..

["P. Christeas" <p_christ-U04EIuiosng@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 573 bytes --]

> Since software_suspend() gets called from there and IIRC thats not part
> of the acpi subsytem I wonder why S4 would not work in case state is
> correctly set there...
>
> Anyway, thats only a quick shot assumption so do not flame in case
> I am plain wrong ;)
>

I already solved the bug. Don't try any more..

To A.Grover: please apply the patch (or just the '!' yourself).
I'd like the two extra messages to be always logged. It's your call to keep 
them.

Can you give me a one-line explanation for those messages I get with S4? Is 
the S1 warning of any importance?

[-- Attachment #2: sleep.diff --]
[-- Type: text/x-diff, Size: 1060 bytes --]

diff -bBaur ./drivers/acpi/sleep.c /usr/src/linux/drivers/acpi/sleep.c
--- ./drivers/acpi/sleep.c	2002-09-28 14:05:32.000000000 +0300
+++ /usr/src/linux/drivers/acpi/sleep.c	2002-09-30 19:11:58.000000000 +0300
@@ -329,8 +329,9 @@
 	state_string[count] = '\0';

 	state = simple_strtoul(state_string, NULL, 0);
+	printk(KERN_INFO PREFIX "sleep: S%d written\n", state);

-	if (sleep_states[state])
+	if (!sleep_states[state])
 		return_VALUE(-ENODEV);

 #ifdef CONFIG_SOFTWARE_SUSPEND
@@ -341,6 +342,8 @@
 #endif
 	status = acpi_suspend(state);

+	printk(KERN_INFO PREFIX "sleep: S%d resumed w. status 0x%x\n", state, status);
+
 	if (ACPI_FAILURE(status))
 		return_VALUE(-ENODEV);

@@ -665,7 +668,7 @@
 	if (acpi_disabled)
 		return_VALUE(0);

-	printk(KERN_INFO PREFIX "(supports");
+	printk(KERN_INFO PREFIX "Sleep supports");
 	for (i=0; i<ACPI_S_STATE_COUNT; i++) {
 		u8 type_a, type_b;
 		status = acpi_get_sleep_type_data(i, &type_a, &type_b);
@@ -674,7 +677,7 @@
 			printk(" S%d", i);
 		}
 	}
-	printk(")\n");
+	printk("\n");


 	/* 'sleep' [R/W]*/


[-- Attachment #3: messages.bz2 --]
[-- Type: application/x-bzip2, Size: 609 bytes --]