S1 on toshiba S3000-X11

S1 on toshiba S3000-X11

[Éric Brunet]

Hi,

I just wanted to say that the acpi patch 20021002 seems to work fine on
my laptop (toshiba S3000-X11) with a 2.4.20-pre10 kernel, except that I
need to apply the following patch (originally by Bruno Ducrot) to have S1
working:

==================================================================================================
--- linux-2.4.20-pre10-acpi1002/drivers/acpi/hardware/hwsleep.c.orig	Tue Oct  8 18:29:35 2002
+++ linux-2.4.20-pre10-acpi1002/drivers/acpi/hardware/hwsleep.c	Tue Oct  8 22:48:49 2002
@@ -309,6 +309,9 @@

        } while (!in_value);

+       /* Restore BM arbitration */
+       acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_DO_NOT_LOCK);
+
        return_ACPI_STATUS (AE_OK);
 }

===================================================================================================

Regards,

	Éric Brunet


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: S1 on toshiba S3000-X11

[Ducrot Bruno]

[-- Attachment #1: Type: text/plain, Size: 1094 bytes --]

On Thu, Oct 10, 2002 at 11:53:02AM +0200, Éric Brunet wrote:
> Hi,
> 
> I just wanted to say that the acpi patch 20021002 seems to work fine on
> my laptop (toshiba S3000-X11) with a 2.4.20-pre10 kernel, except that I
> need to apply the following patch (originally by Bruno Ducrot) to have S1
> working:
> 
> ==================================================================================================
> --- linux-2.4.20-pre10-acpi1002/drivers/acpi/hardware/hwsleep.c.orig	Tue Oct  8 18:29:35 2002
> +++ linux-2.4.20-pre10-acpi1002/drivers/acpi/hardware/hwsleep.c	Tue Oct  8 22:48:49 2002
> @@ -309,6 +309,9 @@
> 
>         } while (!in_value);
> 
> +       /* Restore BM arbitration */
> +       acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_DO_NOT_LOCK);
> +
>         return_ACPI_STATUS (AE_OK);
>  }
> 
> ===================================================================================================

I already submmited the attached patch.

Wait and see..

-- 
Ducrot Bruno
http://www.poupinou.org        Page profaissionelle
http://toto.tu-me-saoules.com  Haume page

[-- Attachment #2: bm-fix.diff --]
[-- Type: text/plain, Size: 757 bytes --]

diff -ur linux-2.4.20-pre8.orig/drivers/acpi/hardware/hwsleep.c linux-2.4.20-pre8/drivers/acpi/hardware/hwsleep.c
--- linux-2.4.20-pre8.orig/drivers/acpi/hardware/hwsleep.c	Thu Oct  3 15:41:47 2002
+++ linux-2.4.20-pre8/drivers/acpi/hardware/hwsleep.c	Thu Oct  3 14:29:56 2002
@@ -335,6 +335,8 @@
 
 	ACPI_FUNCTION_TRACE ("Acpi_leave_sleep_state");
 
+	/* Enable BM arbitration */
+	status = acpi_set_register (ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_LOCK);
 
 	/* Ensure Enter_sleep_state_prep -> Enter_sleep_state ordering */
 
@@ -366,9 +368,6 @@
 	if (ACPI_FAILURE (status)) {
 		return_ACPI_STATUS (status);
 	}
-
-	/* Disable BM arbitration */
-	status = acpi_set_register (ACPI_BITREG_ARB_DISABLE, 0, ACPI_MTX_LOCK);
 
 	return_ACPI_STATUS (status);
 }