Re: ACPI Source patches updated (20021022)

["Ville Syrjälä" <syrjala-ORSVBvAovxo@public.gmane.org>]

On Thu, Oct 24, 2002 at 10:29:04AM -0500, Kai Germaschewski wrote:
> Well, this patch is obviously not correct, consider the case where the 
> loop is executed more than once.
> 
> I think it should be
> 
> 	while (!irq && bridge->bus->self) {
> 		pin = (pin + PCI_SLOT(bridge->devfn)) % 4;
> 		bridge = bridge->bus->self;
> 		irq = acpi_pci_irq_lookup(0, bridge->bus->number, PCI_SLOT(bridge->devfn), pin);
> 	}

Yes I see the logic in that. But I don't know enough about PCI to relly
understand how things work. Over one iteration this does exactly what my
patch did and that's what I care about :) Is it even realistic to expect
that multiple bridges are lined up so that the loop would get executed
more than once?

-- 
Ville Syrjälä
syrjala-ORSVBvAovxo@public.gmane.org
http://www.sci.fi/~syrjala/


-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0003en