[PATCH] Add CONFIG_ACPI_RELAXED_AML option

[NoZizzing OrDripping <nozizzingordripping-/E1597aS9LQAvxtiuMwx3w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 839 bytes --]

The patch adds a new configuration option,
CONFIG_ACPI_RELAXED_AML.  When turned on,
the ACPI code will become forgiving of minor
errors in the AML code.

For this first cut, the patch and option will ignore
region size errors.  An off-by-one error is often
found in the AML shipped with Toshiba laptops,
even new models. This minor error prevents the
AC module from operating without this patch.

I urge the adoption of this patch (or something
similar) into the ACPI code.  This will make it
much easier to install and proliferate Linux on
a large category of laptops.

Rick Richardson
rickr-EySxSuIQeMUAvxtiuMwx3w@public.gmane.org
[Sorry, have to use my Yahoo account to post to this list)

__________________________________________________
Do you Yahoo!?
Yahoo! Mail Plus - Powerful. Affordable. Sign up now.
http://mailplus.yahoo.com

[-- Attachment #2: relaxed-aml.diff --]
[-- Type: application/octet-stream, Size: 2169 bytes --]

diff -u -r linux-2.4.20+acpi-20021205/Documentation/Configure.help linux-2.4.20+acpi-20021205+rick/Documentation/Configure.help
--- linux-2.4.20+acpi-20021205/Documentation/Configure.help	2002-12-12 14:25:15.000000000 -0600
+++ linux-2.4.20+acpi-20021205+rick/Documentation/Configure.help	2002-12-12 13:42:40.000000000 -0600
@@ -18406,6 +18406,14 @@
   of verbosity. Saying Y enables these statements. This will increase
   your kernel size by around 50K.
 
+ACPI Relaxed AML Checking
+CONFIG_ACPI_RELAXED_AML
+  If you say `Y' here, the ACPI interpreter will relax its checking
+  for valid AML and will ignore some AML mistakes, such as off-by-one
+  errors in region sizes.  Some laptps may require this option.  In
+  particular, many Toshiba laptops require this for correct operation
+  of the AC module.
+
 ACPI Bus Manager
 CONFIG_ACPI_BUSMGR
   The ACPI Bus Manager enumerates devices in the ACPI namespace, and
diff -u -r linux-2.4.20+acpi-20021205/drivers/acpi/Config.in linux-2.4.20+acpi-20021205+rick/drivers/acpi/Config.in
--- linux-2.4.20+acpi-20021205/drivers/acpi/Config.in	2002-12-07 08:11:29.000000000 -0600
+++ linux-2.4.20+acpi-20021205+rick/drivers/acpi/Config.in	2002-12-12 13:31:23.000000000 -0600
@@ -36,6 +36,7 @@
       fi
       tristate     '  Toshiba Laptop Extras'	CONFIG_ACPI_TOSHIBA
       bool         '  Debug Statements'	CONFIG_ACPI_DEBUG
+      bool         '  Relaxed AML Checking'	CONFIG_ACPI_RELAXED_AML
     fi
   fi
 
diff -u -r linux-2.4.20+acpi-20021205/drivers/acpi/executer/exfldio.c linux-2.4.20+acpi-20021205+rick/drivers/acpi/executer/exfldio.c
--- linux-2.4.20+acpi-20021205/drivers/acpi/executer/exfldio.c	2002-12-07 08:11:30.000000000 -0600
+++ linux-2.4.20+acpi-20021205+rick/drivers/acpi/executer/exfldio.c	2002-12-12 14:04:49.000000000 -0600
@@ -121,7 +121,11 @@
 			field_datum_byte_offset, obj_desc->common_field.access_byte_width,
 			rgn_desc->region.node->name.ascii, rgn_desc->region.length));
 
-		return_ACPI_STATUS (AE_AML_REGION_LIMIT);
+		#ifdef CONFIG_ACPI_RELAXED_AML
+			return_ACPI_STATUS (AE_OK);
+		#else
+			return_ACPI_STATUS (AE_AML_REGION_LIMIT);
+		#endif
 	}
 
 	return_ACPI_STATUS (AE_OK);