public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>
To: Ducrot Bruno <poup-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>
Cc: Pavel Machek <pavel-AlSwsSmVLrQ@public.gmane.org>,
	"Grover,
	Andrew" <andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [ACPI] [PATCH] acpi_wakeup fixes
Date: Sat, 21 Dec 2002 13:01:02 +0100	[thread overview]
Message-ID: <20021221120101.GA1371@zaurus> (raw)
In-Reply-To: <20021217202142.GB1012-j6u/t2rXLliUoIHC/UFpr9i2O/JbrIOy@public.gmane.org>

Hi!

> @@ -41,7 +41,7 @@
>  	cmpl	_0x12345678, %eax
>  	jne	bogus_real_magic
>  
> -#if 1
> +#if 0
>  	lcall   _0xc000,_3
>  #endif
>  #if 0

We should make this runtime configurable...

Anyway disabling this is probably right.

> @@ -69,8 +69,12 @@
>  
>  	movl	real_save_cr0 - wakeup_code, %eax
>  	movl	%eax, %cr0
> +
> +	# flush the prefetch queue.
>  	jmp 1f
> +1:	jmp 1f
>  1:

Is this really neccessary? One jump should be
ok...

> @@ -160,11 +164,12 @@
>  	ALIGN
>  
>  
> -.org	0x2000
> +.org	0x800
>  wakeup_stack:
> -.org	0x3000
> +.org	0x900
>  ENTRY(wakeup_end)
> -.org	0x4000
> +# .org	0x1000
> +	.align 4096

Kill the comment, otherwise ok.

>  wakeup_pmode_return:
>  	movl	___KERNEL_DS, %eax


-- 
				Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...

  parent reply	other threads:[~2002-12-21 12:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-12-17 20:21 [PATCH] acpi_wakeup fixes Ducrot Bruno
     [not found] ` <20021217202142.GB1012-j6u/t2rXLliUoIHC/UFpr9i2O/JbrIOy@public.gmane.org>
2002-12-21 12:01   ` Pavel Machek [this message]
     [not found]     ` <20021221120101.GA1371-XqDnSF8rrUM@public.gmane.org>
2002-12-30 15:51       ` kacpid respawning under linux-2.4.20 on Toshiba Satellite 5105 Ken Hughes
2003-01-14 17:56   ` [ACPI] acpi_wakeup fixes: Patch? P. Christeas
     [not found]     ` <200301141956.23716.p_christ-U04EIuiosng@public.gmane.org>
2003-01-14 19:52       ` Ducrot Bruno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20021221120101.GA1371@zaurus \
    --to=pavel-alswssmvlrq@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=andrew.grover-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=poup-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox