WARN: please read if you applyied 00_thinkpad_workaround.diff (Re: IBM Thinkpad A31 | News)

[Ducrot Bruno <ducrot-kk6yZipjEM5g9hUCZPvPmw@public.gmane.org>]

On Sat, Jan 18, 2003 at 05:45:25PM +0100, Ducrot Bruno wrote:
Hi Dom,
> > >
> > > Cheers,
> > 
> 
> Here is then.
> 
> This patch is against acpi-20030109.  It override the

..

Ouch.  Just realize that the portion:

> +acpi_status
> +acpi_os_table_override(struct acpi_table_header * existing_table,
> +		       struct acpi_table_header ** new_table)
> +{
> +	if (!existing_table || !new_table)
> +		return AE_BAD_PARAMETER;
> +
> +	if (!memcmp(existing_table->signature, "ECDT", 4)) {
> +		struct acpi_table_ecdt *old = (struct acpi_table_ecdt *) existing_table;
> +		struct acpi_table_ecdt **new = (struct acpi_table_ecdt **) new_table;
> +
> +		if (!memcmp(old->header.oem_id, "IBM", 3))
> +			return (verify_ibm_ecdt(old, new));
> +	}
> +	return AE_OK;
> +}

That can let *new_table to be not NULL if we do not enter
the if statement.

It should be:

acpi_status
acpi_os_table_override(struct acpi_table_header * existing_table,
		       struct acpi_table_header ** new_table)
{
	if (!existing_table || !new_table)
		return AE_BAD_PARAMETER;

	*new_table = NULL;

	if (!memcmp(existing_table->signature, "ECDT", 4)) {
		struct acpi_table_ecdt *old = (struct acpi_table_ecdt *) existing_table;
		struct acpi_table_ecdt **new = (struct acpi_table_ecdt **) new_table;

		if (!memcmp(old->header.oem_id, "IBM", 3))
			return (verify_ibm_ecdt(old, new));
	}
	return AE_OK;
}

Or else you will have a kernel oops at acpi init stage.

Cheers,

-- 
Ducrot Bruno

--  Which is worse:  ignorance or apathy?
--  Don't know.  Don't care.


-------------------------------------------------------
This SF.NET email is sponsored by: Thawte.com - A 128-bit supercerts will
allow you to extend the highest allowed 128 bit encryption to all your 
clients even if they use browsers that are limited to 40 bit encryption. 
Get a guide here:http://ads.sourceforge.net/cgi-bin/redirect.pl?thaw0030en