Re: Code obfuscation in acpi

Pavel Machek
2003-01-18T22:39:59Z

Hi!

> > #define acpi_driver_data(d) ((d)->driver_data)
> >
> > ... very nice for obfuscating code ...
>
> sysfs-based buses use <foo>_{get,set}_drvdata, which looks exactly the
> same as this here.

I think such wrappers are really bad idea, see for example this: I
thought "what kind of cleverness is going on here,", and it was very
simple in fact.

else {
entry->proc_fops = &acpi_thermal_state_fops;
entry->data = acpi_driver_data(device);
}

--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.