From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: "P. Christeas" <p_christ-U04EIuiosng@public.gmane.org>
Cc: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Andre Hedrick <andre-QA/0nRrxPJrNLxjTenLetw@public.gmane.org>
Subject: Re: Snore: BUG in ide-disk on suspend
Date: Mon, 20 Jan 2003 19:38:50 +0100 [thread overview]
Message-ID: <20030120183850.GB530@zaurus> (raw)
In-Reply-To: <200301152234.26117.p_christ-U04EIuiosng@public.gmane.org>
Hi!
> drivers/ide/ide-disk.c: (around 1557)
> printk(KERN_INFO "suspending: %s ", drive->name);
> do_idedisk_standby(drive);
> drive->blocked = 1;
>
> BUG_ON (HWGROUP(drive)->handler);
>
> AFAIK handler is set whenever an irq is being handled (correct me if I'm
> wrong). ide irqs are very often on the system and may happen between the
> actual call to 'ide_do_cmd' (called by do_idedisk_standby) and the
> "blocked=1" line.
blocked=1 is basically sanity check; not critical.
Userland should not be alive at this point, so
there should be noone to ask for work to do,
and when there's no work, there should be no
interrupts.
--
Pavel
Written on sharp zaurus, because my Velo1 broke. If you have Velo you don't need...
-------------------------------------------------------
This SF.NET email is sponsored by:
SourceForge Enterprise Edition + IBM + LinuxWorld = Something 2 See!
http://www.vasoftware.com
next prev parent reply other threads:[~2003-01-20 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-01-15 20:34 Snore: BUG in ide-disk on suspend P. Christeas
[not found] ` <200301152234.26117.p_christ-U04EIuiosng@public.gmane.org>
2003-01-20 18:38 ` Pavel Machek [this message]
[not found] ` <20030120183850.GB530-XqDnSF8rrUM@public.gmane.org>
2003-01-28 10:24 ` Andre Hedrick
2003-01-28 18:24 ` P. Christeas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030120183850.GB530@zaurus \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=andre-QA/0nRrxPJrNLxjTenLetw@public.gmane.org \
--cc=p_christ-U04EIuiosng@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox