public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org
To: acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Cc: ltong-r3+FECOBLOPAaqN1iTbosg@public.gmane.org
Subject: Possible problem in acpi_remove_address_space_handler
Date: Wed, 09 Apr 2003 12:35:48 -0400	[thread overview]
Message-ID: <200304091635.h39GZmp06599@throb.netspace.org> (raw)

Is there any reason why 	

acpi_ut_remove_reference (handler_obj); 

is called twice in a row in acpi_remove_address_space_handler
events/evxfregn.c line 400 or so?


If it's a typo, then I think I found the thing causing the
AC_BAD_PARAMETER problem on my Thinkpad R32.  Maybe someone already
found this.


Here's my patch:


diff -u -r1.1.1.1 evxfregn.c
--- linux-2.5.66/drivers/acpi/events/evxfregn.c	2 Apr 2003 03:34:04 -0000	1.1.1.1
+++ linux-2.5.66/drivers/acpi/events/evxfregn.c	9 Apr 2003 16:18:25 -0000
@@ -391,7 +391,7 @@
 			/*
 			 * Now we can delete the handler object
 			 */
-			acpi_ut_remove_reference (handler_obj);
+
 			acpi_ut_remove_reference (handler_obj);
 
 			goto unlock_and_exit;



--
"Operation Shoot First" is a complete success!!!
Brian Perkins                bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org 


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

             reply	other threads:[~2003-04-09 16:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-09 16:35 bperkins-ooduxAEi7gVg9hUCZPvPmw [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-04-09 22:50 Possible problem in acpi_remove_address_space_handler Moore, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200304091635.h39GZmp06599@throb.netspace.org \
    --to=bperkins-ooduxaei7gvg9huczpvpmw@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=ltong-r3+FECOBLOPAaqN1iTbosg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox