IBM Thinkpad R32 and ACPI

IBM Thinkpad R32 and ACPI

[Michael Wahlbrink]

Hi all,
since I've this fine new Thinkpad (Chrismas) I'm trying from time to time to get acpy running with linux. Ok the present state is the following:
- I've to run with the fixed ecdt-table.
- If I run 2.4.21-pre6-acpi i get these error-messages
  also mentioned before like: 
  ACPI-0341: *** Error: Handler for [SystemMemory] returned AE_BAD_PARAMETER
- If I do the hack with commenting out the 
  "if (ec_ecdt && ec_ecdt->uid == uid) {...}" block 
  in acpi_ec_add() of ec.c. Acpi will start without error messages and I'll
  get no more errors when I press a button, but the only buttons which
  will report actions in /proc/acpi/event are the lid button and the sllep 
  button (fn+F4). All other buttons (also the power-button) are "acpi-dead".
What to try now?? Any ideas?? Shoud I start fiddling around with the DST or should I try a 2.5.xx kernel?? 
Any help apreciated
regards
micha


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

Re: IBM Thinkpad R32 and ACPI

[bperkins-ooduxAEi7gVg9hUCZPvPmw]

This problem is supposed to be fixed in the next release(see the archives).

The problem was solved for me (on my R32) by going to 
drivers/acpi/events/evxfregn.c
and removing one of the 

acpi_ut_remove_reference (handler_obj);

lines (there are two). 
This might also help other Thinkpad users who have similar problems.


Let me know how it goes.  Sleep functionality seems pretty broken at
the moment.

 Here's a patch, if you prefer.

diff -u -r1.1.1.1 evxfregn.c
--- linux-2.5.66/drivers/acpi/events/evxfregn.c	2 Apr 2003 03:34:04 -0000	1.1.1.1
+++ linux-2.5.66/drivers/acpi/events/evxfregn.c	9 Apr 2003 16:18:25 -0000
@@ -391,7 +391,7 @@
 			/*
 			 * Now we can delete the handler object
 			 */
-			acpi_ut_remove_reference (handler_obj);
+
 			acpi_ut_remove_reference (handler_obj);
 
 			goto unlock_and_exit;




--
Brian Perkins                                bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

Re: IBM Thinkpad R32 and ACPI

[Lu Tong]

I tried the patch on my x22. it fixed the problem. nice catch, Brian. 
as far as the sleep mode, S4 worked for me couples of weeks ago, but not any more. sad.

--ltong

On Sat, Apr 12, 2003 at 02:12:06PM -0400, bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org wrote:
> This problem is supposed to be fixed in the next release(see the archives).
> 
> The problem was solved for me (on my R32) by going to 
> drivers/acpi/events/evxfregn.c
> and removing one of the 
> 
> acpi_ut_remove_reference (handler_obj);
> 
> lines (there are two). 
> This might also help other Thinkpad users who have similar problems.
> 
> 
> Let me know how it goes.  Sleep functionality seems pretty broken at
> the moment.
> 
>  Here's a patch, if you prefer.
> 
> diff -u -r1.1.1.1 evxfregn.c
> --- linux-2.5.66/drivers/acpi/events/evxfregn.c	2 Apr 2003 03:34:04 -0000	1.1.1.1
> +++ linux-2.5.66/drivers/acpi/events/evxfregn.c	9 Apr 2003 16:18:25 -0000
> @@ -391,7 +391,7 @@
>  			/*
>  			 * Now we can delete the handler object
>  			 */
> -			acpi_ut_remove_reference (handler_obj);
> +
>  			acpi_ut_remove_reference (handler_obj);
>  
>  			goto unlock_and_exit;
> 
> 
> 
> 
> --
> Brian Perkins                                bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
> for complex code. Debugging C/C++ programs can leave you feeling lost and 
> disoriented. TotalView can help you find your way. Available on major UNIX 
> and Linux platforms. Try it free. www.etnus.com
> _______________________________________________
> Acpi-devel mailing list
> Acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/acpi-devel


-------------------------------------------------------
This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger 
for complex code. Debugging C/C++ programs can leave you feeling lost and 
disoriented. TotalView can help you find your way. Available on major UNIX 
and Linux platforms. Try it free. www.etnus.com

Re: IBM Thinkpad R32 and ACPI

[Michael Wahlbrink]

On Sat, 12 Apr 2003 14:12:06 -0400
bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org wrote:

> This problem is supposed to be fixed in the next release(see the archives).
> 
> The problem was solved for me (on my R32) by going to 
> drivers/acpi/events/evxfregn.c
> and removing one of the 
> 
> acpi_ut_remove_reference (handler_obj);
> 
> lines (there are two). 
> This might also help other Thinkpad users who have similar problems.
> 
> 
> Let me know how it goes.  Sleep functionality seems pretty broken at
> the moment.
> 
Hi Brian,
Hmm, it have the same effect like commenting out these "if (ec_ecdt && ec_ecdt->uid == uid) {...}" block in acpi_ec_add() of ec.c. No errormessages anymore but also no events from the powerbutton...
I'll no try for testing a kernel with both hacks ;-) ...
And I'll give 2.5.66 a shot to see if it makes a difference ....
thanks for the quick response
regards
micha

ps: which BIOS revision are you running on your R32?


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf

Re: IBM Thinkpad R32 and ACPI

[Michael Wahlbrink]

On Tue, 15 Apr 2003 13:47:30 -0400
bperkins-ooduxAEi7gVg9hUCZPvPmw@public.gmane.org wrote:

> Michael Wahlbrink <linux.wali-Mmb7MZpHnFY@public.gmane.org> writes:
> 
> 
> > Hi Brian, Hmm, it have the same effect like commenting out these "if
> > (ec_ecdt && ec_ecdt->uid == uid) {...}" block in acpi_ec_add() of
> > ec.c. No errormessages anymore but also no events from the
> > powerbutton...  I'll no try for testing a kernel with both hacks ;-)
> 
> Nothing interesting will happen.  The ec_add is a hack, my fix is (at
> least closer to) a real fix.  If you comment it out the "fixed" code
> won't even get called.
> 
> > ...  And I'll give 2.5.66 a shot to see if it makes a difference
> > ....  thanks for the quick response regards micha
> 
>  I think I noticed the same problem, but I guess I didn't really care.
> I'm not sure it's worth the effort until the sleep functions are
> fixed.  You might be able to get somewhere if you looked at the DSDT
> table, I dunno.  It may be possible that the power button isn't
> controlled by acpi.
Hmmm, it seems that it is also controlled by acpi, because in a kernel without your fix the Powerbutton produces also these errormessages like the volume keys and all fn+Fx (only fn+F4) always gives the right action... So as I see the things in the moment, I prevent with the fix from giving the errors, but I'm not get any more usable events in /proc/acpi/events  cause fn+F4 and the LID-switch worked also before. The only difference in usability is that I can now use fn+F7 again to switch between the displays (internal/external).

> Good luck!
It seem that I'll need it for acpi on that Laptop....

Thanks to all who work on ACPI-support for linux

regards
micha


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf