acpi_irq_to_vector()

acpi_irq_to_vector()

[Matthew Wilcox]

In the 2.5 ia64 patch, there's a lot of places which look like this:

@@ -251,7 +251,14 @@
        irq = acpi_fadt.sci_int;

 #ifdef CONFIG_IA64
-       irq = gsi_to_vector(irq);
+       int vector;
+
+       vector = acpi_irq_to_vector(irq);
+       if (vector < 0) {
+               printk(KERN_ERR PREFIX "SCI (IRQ%d) not registerd\n", irq);
+               return AE_OK;
+       }
+       irq = vector;
 #endif
        acpi_irq_irq = irq;

ok, we renamed gsi_to_vector to acpi_irq_to_vector(); that's fine.
But we still have that ugly ifdef in there.  Any resistance to defining
acpi_irq_to_vector to simply return its value on non-ia64 platforms?

Then it'd look like:

	irq = acpi_fadt.sci_int;
	vector = acpi_irq_to_vector(irq);
	if (vector < 0) {
		printk(KERN_ERR PREFIX "SCI (IRQ%d) not registered\n", irq);
		return AE_OK;
	}
	acpi_irq_irq = vector;
	acpi_irq_handler = handler;
	acpi_irq_context = context;
	if (request_irq(vector, acpi_irq, SA_SHIRQ, "acpi", acpi_irq)) {
...		

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk


-------------------------------------------------------
This SF.net email is sponsored by:  Etnus, makers of TotalView, The best
thread debugger on the planet. Designed with thread debugging features
you've never dreamed of, try TotalView 6 free at www.etnus.com.

Re: acpi_irq_to_vector()

[Matthew Wilcox]

On Thu, Jun 05, 2003 at 08:22:53PM +0100, Matthew Wilcox wrote:
> ok, we renamed gsi_to_vector to acpi_irq_to_vector(); that's fine.
> But we still have that ugly ifdef in there.  Any resistance to defining
> acpi_irq_to_vector to simply return its value on non-ia64 platforms?
> 
> Then it'd look like:
> 
> 	irq = acpi_fadt.sci_int;
> 	vector = acpi_irq_to_vector(irq);
> 	if (vector < 0) {
> 		printk(KERN_ERR PREFIX "SCI (IRQ%d) not registered\n", irq);
> 		return AE_OK;
> 	}
> 	acpi_irq_irq = vector;
> 	acpi_irq_handler = handler;
> 	acpi_irq_context = context;
> 	if (request_irq(vector, acpi_irq, SA_SHIRQ, "acpi", acpi_irq)) {

Since nobody's arguing with me, I'm going to argue with myself ;-)

For PCI devices, we just read the irq out of the struct pci_dev.
The platform code gets the opportunity to mangle the irq in whatever
way it chooses before the pci_dev is passed to the driver.  Can we do
something similar for ACPI instead?

-- 
"It's not Hollywood.  War is real, war is primarily not about defeat or
victory, it is about death.  I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk


-------------------------------------------------------
This SF.NET email is sponsored by: eBay
Great deals on office technology -- on eBay now! Click here:
http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5