public inbox for linux-acpi@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
To: Matthew Wilcox <willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
Cc: linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: ACPI vs PCI: configuration space
Date: Wed, 18 Jun 2003 15:30:03 -0700	[thread overview]
Message-ID: <20030618223003.GA2134@kroah.com> (raw)
In-Reply-To: <20030618221752.GY24357-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>

On Wed, Jun 18, 2003 at 11:17:52PM +0100, Matthew Wilcox wrote:
> 
> It's kind of annoying to invent some structures and put some values into
> them only to pull them out again.  This leads to try 5 ...
> 
> struct acpi_pci_ops {
> 	int (*read)(int domain, int bus, int devfn, int where, int size, u32 *val);
> 	int (*write)(int domain, int bus, int devfn, int where, int size, u32 val);
> }
> 
> It reduces stack consumption, which is a clear win ... it's also _incredibly_
> easy to implement since all the existing pci_ops call functions which take
> exactly this form.
> 
> Go on, approve Try 5.  You know you want to ;-)

So for i386, what would domain be?

Anyway, yeah, I agree with try 5, that seems the most sane.

thanks,

greg k-h


-------------------------------------------------------
This SF.Net email is sponsored by: INetU
Attention Web Developers & Consultants: Become An INetU Hosting Partner.
Refer Dedicated Servers. We Manage Them. You Get 10% Monthly Commission!
INetU Dedicated Managed Hosting http://www.inetu.net/partner/index.php

  parent reply	other threads:[~2003-06-18 22:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-18 22:17 ACPI vs PCI: configuration space Matthew Wilcox
     [not found] ` <20030618221752.GY24357-+pPCBgu9SkPzIGdyhVEDUDl5KyyQGfY2kSSpQ9I8OhVaa/9Udqfwiw@public.gmane.org>
2003-06-18 22:30   ` Greg KH [this message]
     [not found]     ` <20030618223003.GA2134-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2003-06-18 23:00       ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030618223003.GA2134@kroah.com \
    --to=greg-u8xffu+wg4eavxtiumwx3w@public.gmane.org \
    --cc=acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=willy-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox